Skip to content

Conversation

@zesu22
Copy link
Contributor

@zesu22 zesu22 commented Nov 28, 2025

Summary by CodeRabbit

  • Documentation

    • Updated Khmer localization text for consent checkbox wording.
  • New Features

    • Added offline and online connectivity status indicators.
  • Updates

    • Refreshed Terms & Conditions and Privacy Policy text in English and Khmer.
    • Updated identity service references throughout localized content.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>
@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Walkthrough

Updates localization strings and documentation for the signup UI to replace KHID identity service references with UIN, adjust Khmer consent checkbox phrasing, remove "Cambodia's" from English terms text, and add offline/online connectivity polling prompts to translations.

Changes

Cohort / File(s) Change Summary
Documentation
docs/design/dynamic-forms.md
Updated Khmer label text of consent checkbox to more generic phrasing with revised trailing clause.
English Localization
signup-ui/public/locales/en.json
Removed "Cambodia's" possessive from terms agreement string; replaced all KHID references with UIN across terms and conditions and privacy policy content blocks.
Khmer Localization
signup-ui/public/locales/km.json
Updated Khmer consent checkbox wording with adjusted spacing; replaced KHID with UIN throughout terms and conditions and privacy policy content; added two new fields for offline/online connectivity polling prompts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify consistency of KHID → UIN replacements across all three locale files and documentation
  • Confirm Khmer and English wording changes are semantically aligned
  • Check that new connectivity polling fields are properly integrated into the UI flow

Possibly related PRs

Suggested reviewers

  • vadherhemant
  • ase-101

Poem

🐰 The KHID has transformed to UIN so fine,
From Cambodia's clasp to a standard design,
Khmer words dance with fresh, cleaner lines,
Online or offline, the rabbit's work shines! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[DOC-FIX] used country neutral name in docs & locales' accurately describes the main change: replacing country-specific references (Cambodia/KHID) with country-neutral alternatives (UIN) across documentation and localization files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e04079 and d08dae2.

📒 Files selected for processing (3)
  • docs/design/dynamic-forms.md (1 hunks)
  • signup-ui/public/locales/en.json (2 hunks)
  • signup-ui/public/locales/km.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: signup-ui / build-dockers
  • GitHub Check: build-maven-ui-test / maven-build
  • GitHub Check: build_maven_apitest_esignet_signup / maven-build
  • GitHub Check: build_maven_esignet_signup / maven-build
🔇 Additional comments (3)
signup-ui/public/locales/km.json (1)

35-35: Approve localization updates for UIN terminology and connectivity polling.

The Khmer locale file has been properly updated with:

  • Country-neutral phrasing (removed possessive references)
  • KHID → UIN terminology replacements in terms and privacy content
  • New connectivity polling prompts (offline/online status messages)

All changes are consistent with the English locale file structure and component anchor naming. The Khmer text appears professionally translated and properly formatted for user-facing display.

Also applies to: 85-86, 90-91

signup-ui/public/locales/en.json (1)

90-91: I was unable to clone the repository to execute the verification script. However, the original review comment raises a valid concern that needs to be addressed.

Verify polling prompts are synchronized across locale files.

New connectivity polling prompts offline_polling_prompt and online_polling_prompt have been added to signup-ui/public/locales/en.json. Confirm that both keys are present with appropriate Khmer translations in signup-ui/public/locales/km.json.

docs/design/dynamic-forms.md (1)

199-199: I'm unable to complete the verification due to a repository cloning failure. However, I can assess the review comment based on the information provided.

Verification inconclusive due to repository access limitations.

The requested verification cannot be completed because the repository cannot be accessed in the sandbox environment. However, the original review comment's concern is valid: consistency between documentation and locale files should be maintained. The review asks for a reasonable verification — comparing the Khmer consent text in the documentation against the corresponding entry in the locale file.

No action can be taken to verify the consistency claim without access to the repository files. A maintainer or CI system with repository access should confirm that the Khmer text in docs/design/dynamic-forms.md line 199 matches the terms_and_condition key value in signup-ui/public/locales/km.json.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ase-101
Copy link
Contributor

ase-101 commented Nov 28, 2025

We will take this as part of the 1.7.1 patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants