-
Notifications
You must be signed in to change notification settings - Fork 151
Updated pom version #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pom version #1563
Conversation
Signed-off-by: pvsaidurga <saidurgacsea@gmail.com>
WalkthroughVersion bump of esignet project from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT across parent POM references in multiple modules and root POM. Additionally, plugin versions are updated to 1.4.0-SNAPSHOT in esignet-with-plugins, and module versions are bumped in esignet-service and esignet-with-plugins. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
esignet-with-plugins/pom.xml (1)
11-11: Consider aligning module version with inherited pattern.The module uses explicit version
1.8.0-SNAPSHOT(line 15) instead of${project.parent.version}like other modules. If this is a distinct packaging artifact with its own release cycle, the explicit version is fine; otherwise, adopting the property-based pattern would reduce maintenance burden and ensure consistency.Can you clarify whether esignet-with-plugins intentionally uses an explicit version separate from the parent, or if it should inherit via
${project.parent.version}?Also applies to: 15-15
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
binding-service-impl/pom.xml(1 hunks)client-management-service-impl/pom.xml(1 hunks)consent-service-impl/pom.xml(1 hunks)esignet-core/pom.xml(1 hunks)esignet-integration-api/pom.xml(1 hunks)esignet-service/pom.xml(1 hunks)esignet-with-plugins/pom.xml(2 hunks)oidc-service-impl/pom.xml(1 hunks)pom.xml(1 hunks)
🔇 Additional comments (9)
oidc-service-impl/pom.xml (1)
9-9: LGTM! Version bump correctly propagates parent version via property inheritance.Also applies to: 14-14
pom.xml (1)
17-17: LGTM! Root parent version correctly updated; child modules inherit via parent reference.esignet-integration-api/pom.xml (1)
9-9: LGTM! Parent version correctly bumped and properly inherited by module.Also applies to: 14-14
client-management-service-impl/pom.xml (1)
9-9: LGTM! Parent version updated and dependency chain properly propagates version via properties.Also applies to: 14-14, 18-18, 31-31
binding-service-impl/pom.xml (1)
11-11: LGTM! Parent version updated; module and dependency versions correctly chain through properties.Also applies to: 17-17, 21-21, 34-34
esignet-core/pom.xml (1)
12-12: LGTM! Parent version correctly updated; esignet-integration-api dependency properly aligned with project version.Also applies to: 17-17, 165-165
esignet-with-plugins/pom.xml (1)
78-78: LGTM! Plugin versions consistently updated to 1.4.0-SNAPSHOT across all artifact references.Please verify that the updated plugin versions (mock-plugin, mosip-identity-plugin, sunbird-rc-plugin at 1.4.0-SNAPSHOT) are available in your configured Maven repositories. This will be caught at build time if unavailable, but confirming availability now prevents CI failures.
Also applies to: 80-80, 82-82, 106-106, 114-114, 122-122
consent-service-impl/pom.xml (1)
12-12: LGTM! Parent version updated and dependency version chain correctly configured through properties.Also applies to: 17-17, 23-23, 35-35
esignet-service/pom.xml (1)
11-11: Version bump looks good — verify cross-module consistency and changelog.The parent and project version bumps to 1.8.0-SNAPSHOT are consistent and correctly applied. The use of
${project.version}for internal module dependencies (lines 48, 53, 58, 71, 76) ensures they will resolve to the new version automatically, which is the right approach.Please verify:
Cross-module consistency: Ensure all related modules (esignet-core, esignet-with-plugins, consent-service-impl, binding-service-impl, oidc-service-impl, client-management-service-impl) are also bumped to 1.8.0-SNAPSHOT consistently.
Changelog: Confirm that release notes or a changelog document the changes between 1.7.1-SNAPSHOT and 1.8.0-SNAPSHOT, including any breaking changes or migration steps.
Plugin compatibility: The PR also updates plugin versions to 1.4.0-SNAPSHOT in esignet-with-plugins. Verify that these plugins (mock-plugin, mosip-identity-plugin, sunbird-rc-plugin) are compatible with the new service version.
Also applies to: 16-16
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.