Skip to content

Conversation

@pvsaidurga
Copy link
Contributor

@pvsaidurga pvsaidurga commented Dec 3, 2025

Summary by CodeRabbit

  • Chores
    • Project version updated to 1.8.0-SNAPSHOT across all modules
    • Plugin dependencies updated to version 1.4.0-SNAPSHOT

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: pvsaidurga <saidurgacsea@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Walkthrough

Version bump of esignet project from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT across parent POM references in multiple modules and root POM. Additionally, plugin versions are updated to 1.4.0-SNAPSHOT in esignet-with-plugins, and module versions are bumped in esignet-service and esignet-with-plugins.

Changes

Cohort / File(s) Summary
Service module parent version updates
binding-service-impl/pom.xml, client-management-service-impl/pom.xml, consent-service-impl/pom.xml, oidc-service-impl/pom.xml
Parent version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT
Core and integration parent version updates
esignet-core/pom.xml, esignet-integration-api/pom.xml
Parent version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT
Root POM parent version update
pom.xml
esignet-parent version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT
esignet-service version updates
esignet-service/pom.xml
Parent version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT; project version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT
esignet-with-plugins multi-level updates
esignet-with-plugins/pom.xml
Parent version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT; module version bumped from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT; plugin versions (mock-plugin, mosip-identity-plugin, sunbird-rc-plugin) updated from 1.3.5-SNAPSHOT to 1.4.0-SNAPSHOT

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple, repetitive version number updates across POM configuration files
  • No logic changes, structural modifications, or functional impact
  • Homogeneous set of changes (consistent pattern applied uniformly)

Possibly related PRs

Suggested reviewers

  • ase-101

Poem

🐰 Hops through the pom files with glee,
1.8.0 it shall be!
From Snapshot past to future bright,
Version bumps done just right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Updated pom version' is overly vague and generic. It mentions updating a POM version but doesn't specify that this is a version bump from 1.7.1-SNAPSHOT to 1.8.0-SNAPSHOT across the entire project structure, or that plugin versions were also updated. Consider a more specific title like 'Bump version to 1.8.0-SNAPSHOT and update plugin versions' to better convey the scope and intent of the version upgrade across all modules.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
esignet-with-plugins/pom.xml (1)

11-11: Consider aligning module version with inherited pattern.

The module uses explicit version 1.8.0-SNAPSHOT (line 15) instead of ${project.parent.version} like other modules. If this is a distinct packaging artifact with its own release cycle, the explicit version is fine; otherwise, adopting the property-based pattern would reduce maintenance burden and ensure consistency.

Can you clarify whether esignet-with-plugins intentionally uses an explicit version separate from the parent, or if it should inherit via ${project.parent.version}?

Also applies to: 15-15

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 857f582 and 75d1743.

📒 Files selected for processing (9)
  • binding-service-impl/pom.xml (1 hunks)
  • client-management-service-impl/pom.xml (1 hunks)
  • consent-service-impl/pom.xml (1 hunks)
  • esignet-core/pom.xml (1 hunks)
  • esignet-integration-api/pom.xml (1 hunks)
  • esignet-service/pom.xml (1 hunks)
  • esignet-with-plugins/pom.xml (2 hunks)
  • oidc-service-impl/pom.xml (1 hunks)
  • pom.xml (1 hunks)
🔇 Additional comments (9)
oidc-service-impl/pom.xml (1)

9-9: LGTM! Version bump correctly propagates parent version via property inheritance.

Also applies to: 14-14

pom.xml (1)

17-17: LGTM! Root parent version correctly updated; child modules inherit via parent reference.

esignet-integration-api/pom.xml (1)

9-9: LGTM! Parent version correctly bumped and properly inherited by module.

Also applies to: 14-14

client-management-service-impl/pom.xml (1)

9-9: LGTM! Parent version updated and dependency chain properly propagates version via properties.

Also applies to: 14-14, 18-18, 31-31

binding-service-impl/pom.xml (1)

11-11: LGTM! Parent version updated; module and dependency versions correctly chain through properties.

Also applies to: 17-17, 21-21, 34-34

esignet-core/pom.xml (1)

12-12: LGTM! Parent version correctly updated; esignet-integration-api dependency properly aligned with project version.

Also applies to: 17-17, 165-165

esignet-with-plugins/pom.xml (1)

78-78: LGTM! Plugin versions consistently updated to 1.4.0-SNAPSHOT across all artifact references.

Please verify that the updated plugin versions (mock-plugin, mosip-identity-plugin, sunbird-rc-plugin at 1.4.0-SNAPSHOT) are available in your configured Maven repositories. This will be caught at build time if unavailable, but confirming availability now prevents CI failures.

Also applies to: 80-80, 82-82, 106-106, 114-114, 122-122

consent-service-impl/pom.xml (1)

12-12: LGTM! Parent version updated and dependency version chain correctly configured through properties.

Also applies to: 17-17, 23-23, 35-35

esignet-service/pom.xml (1)

11-11: Version bump looks good — verify cross-module consistency and changelog.

The parent and project version bumps to 1.8.0-SNAPSHOT are consistent and correctly applied. The use of ${project.version} for internal module dependencies (lines 48, 53, 58, 71, 76) ensures they will resolve to the new version automatically, which is the right approach.

Please verify:

  1. Cross-module consistency: Ensure all related modules (esignet-core, esignet-with-plugins, consent-service-impl, binding-service-impl, oidc-service-impl, client-management-service-impl) are also bumped to 1.8.0-SNAPSHOT consistently.

  2. Changelog: Confirm that release notes or a changelog document the changes between 1.7.1-SNAPSHOT and 1.8.0-SNAPSHOT, including any breaking changes or migration steps.

  3. Plugin compatibility: The PR also updates plugin versions to 1.4.0-SNAPSHOT in esignet-with-plugins. Verify that these plugins (mock-plugin, mosip-identity-plugin, sunbird-rc-plugin) are compatible with the new service version.

Also applies to: 16-16

@pvsaidurga pvsaidurga closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant