Updated helm chart versions #1585
Conversation
Signed-off-by: pvsaidurga <saidurgacsea@gmail.com>
WalkthroughThis PR updates deployment configuration files, bumping Helm chart versions to 1.7.1-develop and switching Docker image registries from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
helm/oidc-ui/values.yaml (1)
315-315: Inconsistent registry reference.The
volumePermissions.image.repositorystill referencesmosipid/os-shell, while the main image has been migrated to themosipqaregistry. This inconsistency should be addressed to align with the PR's objective of migrating frommosipid/mosipdevtomosipqa.🔎 Apply this diff to align the registry reference:
- repository: mosipid/os-shell + repository: mosipqa/os-shell
🧹 Nitpick comments (1)
helm/esignet/values.yaml (1)
55-56: Use a fixed version tag instead of the floating 1.7.x reference for deployment reproducibility.The
1.7.xtag is a floating reference that may resolve to different patch versions over time, affecting deployment consistency. Consider pinning to a specific version tag (e.g.,1.7.0,1.7.1) or using an image digest hash for guaranteed reproducibility.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
deploy/esignet-with-plugins/install.sh(1 hunks)deploy/esignet/install.sh(2 hunks)deploy/oidc-ui/install.sh(1 hunks)deploy/postgres/install.sh(1 hunks)docker-compose/docker-compose.yml(2 hunks)helm/esignet/Chart.yaml(1 hunks)helm/esignet/values.yaml(1 hunks)helm/oidc-ui/Chart.yaml(1 hunks)helm/oidc-ui/values.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: Ivanmeneges
Repo: mosip/esignet PR: 1565
File: deploy/keycloak/install.sh:28-29
Timestamp: 2025-12-04T10:54:26.400Z
Learning: The Docker image mosipid/postgresql with tags like 14.2.0-debian-10-r70 is available in the MOSIP ID registry and is used for PostgreSQL deployments in MOSIP projects.
📚 Learning: 2025-12-18T04:10:45.874Z
Learnt from: abhishek8shankar
Repo: mosip/esignet PR: 1581
File: deploy/delete-all.sh:14-14
Timestamp: 2025-12-18T04:10:45.874Z
Learning: In the deploy/delete-all.sh script for the esignet repository, the esignet-softhsm release should be deleted from the "esignet" namespace (not from the "softhsm" namespace), so the hardcoded namespace is intentional.
Applied to files:
deploy/esignet/install.shdeploy/esignet-with-plugins/install.sh
📚 Learning: 2025-12-04T10:54:26.400Z
Learnt from: Ivanmeneges
Repo: mosip/esignet PR: 1565
File: deploy/keycloak/install.sh:28-29
Timestamp: 2025-12-04T10:54:26.400Z
Learning: The Docker image mosipid/postgresql with tags like 14.2.0-debian-10-r70 is available in the MOSIP ID registry and is used for PostgreSQL deployments in MOSIP projects.
Applied to files:
deploy/postgres/install.shdocker-compose/docker-compose.ymlhelm/oidc-ui/values.yamlhelm/esignet/values.yaml
🔇 Additional comments (8)
helm/esignet/Chart.yaml (1)
5-5: LGTM!The chart version bump to
1.7.1-developis consistent with the broader version update across the deployment artifacts.deploy/esignet-with-plugins/install.sh (1)
11-11: LGTM!The chart version update aligns with the corresponding Chart.yaml version bump to
1.7.1-develop.deploy/oidc-ui/install.sh (1)
42-42: LGTM!The chart version update is consistent with the helm/oidc-ui/Chart.yaml version bump to
1.7.1-develop.helm/oidc-ui/Chart.yaml (1)
5-5: LGTM!The chart version bump to
1.7.1-developmaintains consistency across Helm charts in this PR.deploy/esignet/install.sh (1)
26-26: LGTM!The chart version update to
1.7.1-developaligns with the Helm chart version bump.docker-compose/docker-compose.yml (1)
36-36: Verify image availability before deployment.The esignet service image has been updated to
mosipqa/esignet-with-plugins:1.7.x. Confirm this image exists in the mosipqa registry and is accessible. Rundocker manifest inspect mosipqa/esignet-with-plugins:1.7.xto verify availability. If unavailable, adjust to a valid version tag.deploy/postgres/install.sh (1)
50-50: Verify image availability in the mosipqa registry before deployment.The PostgreSQL image repository has been switched from
mosipidtomosipqa. Ensure thatmosipqa/postgresql:14.2.0-debian-10-r70exists and is accessible in the mosipqa registry before deploying, as registry migrations can introduce image availability issues.helm/oidc-ui/values.yaml (1)
54-55: Verify Docker image availability and clarify the1.7.xtag format.The tag has been changed to
1.7.x, which is non-standard for Docker images. While this tag appears consistently across the project (including in Dockerfile references torelease-1.7.xbranches and deployment scripts), Docker image tags typically use specific versions (e.g.,1.7.0,1.7.1) or keywords (e.g.,latest,develop).Before deployment, confirm:
- The image
mosipqa/oidc-ui:1.7.xexists and is accessible in the registry.- Whether
1.7.xis a literal tag, a shorthand for a specific release version, or should reference a different format (e.g.,1.7.0).
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.