-
Notifications
You must be signed in to change notification settings - Fork 150
[ES-2315] again changed workflow configuration to java21 #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
WalkthroughThe push-trigger GitHub Actions workflow is updated to reference Java 21-specific workflow versions across Maven build, Docker build, and related build job executions. All workflow references previously pointing to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/push-trigger.yml (1)
266-266: Updatebuild_dockers_oidc_uiworkflow reference to@master-java21for consistency.Line 266 still references
docker-build.yml@master, while all other Docker build jobs (lines 83, 241, 370, 468) have been updated to@master-java21. This appears to be a missed update given the PR's objective to standardize workflow references to the Java 21 branch.Update line 266 to use
@master-java21:uses: mosip/kattu/.github/workflows/docker-build.yml@master-java21
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/push-trigger.yml
🔇 Additional comments (2)
.github/workflows/push-trigger.yml (2)
61-61: LGTM! Workflow references correctly updated to Java 21.The Maven and Docker build workflows for the esignet service are now properly referencing the
master-java21branch, aligning with the PR objective.Also applies to: 83-83
218-218: LGTM! Additional services correctly migrated to Java 21 workflows.The workflow references for esignet-with-plugins, apitest-esignet, and uitest-esignet have been properly updated to use the
master-java21branch.Also applies to: 241-241, 370-370, 468-468
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.