Skip to content

Conversation

@sacrana0
Copy link
Contributor

@sacrana0 sacrana0 commented Jan 2, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal build infrastructure to use Java 21-compatible workflow configurations for Maven and Docker build processes.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Sachin Rana <sacrana324@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Walkthrough

The push-trigger GitHub Actions workflow is updated to reference Java 21-specific workflow versions across Maven build, Docker build, and related build job executions. All workflow references previously pointing to master branch are changed to master-java21 branch to standardize Java 21 compatibility.

Changes

Cohort / File(s) Summary
Workflow Reference Updates
.github/workflows/push-trigger.yml
Multiple workflow job references updated from master to master-java21 branch, affecting Maven builds (e.g., build_maven_esignet, build_maven_esignet_with_plugins), Docker builds (e.g., build_dockers, build_dockers_esignet_with_plugins, build_dockers_oidc_ui), and API test workflows to enforce Java 21 compatibility across all build pipelines.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ckm007
  • ase-101

Poem

🐰 A hoppy update to workflows so fine,
Java 21 paths now align!
From master to master-java21 we leap,
Maven and Docker builds run deep,
Consistency's carrots, our migration complete! 🥕

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating workflow configuration to use Java 21 across multiple build workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2403b27 and d224390.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml
🔇 Additional comments (2)
.github/workflows/push-trigger.yml (2)

61-61: LGTM! Workflow references correctly updated to Java 21.

The Maven and Docker build workflows for the esignet service are now properly referencing the master-java21 branch, aligning with the PR objective.

Also applies to: 83-83


218-218: LGTM! Additional services correctly migrated to Java 21 workflows.

The workflow references for esignet-with-plugins, apitest-esignet, and uitest-esignet have been properly updated to use the master-java21 branch.

Also applies to: 241-241, 370-370, 468-468


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sacrana0
Copy link
Contributor Author

sacrana0 commented Jan 2, 2026

@coderabbitai help

@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
    • @coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
    • @coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit configuration file (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, support, documentation and community

  • Visit our status page to check the current availability of CodeRabbit.
  • Create a ticket on our support page for assistance with any issues or questions.
  • Visit our documentation site for detailed information on how to use CodeRabbit.
  • Join our Discord community to connect with other users and get help from the community.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/push-trigger.yml (1)

266-266: Update build_dockers_oidc_ui workflow reference to @master-java21 for consistency.

Line 266 still references docker-build.yml@master, while all other Docker build jobs (lines 83, 241, 370, 468) have been updated to @master-java21. This appears to be a missed update given the PR's objective to standardize workflow references to the Java 21 branch.

Update line 266 to use @master-java21:

    uses: mosip/kattu/.github/workflows/docker-build.yml@master-java21
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2403b27 and d224390.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml
🔇 Additional comments (2)
.github/workflows/push-trigger.yml (2)

61-61: LGTM! Workflow references correctly updated to Java 21.

The Maven and Docker build workflows for the esignet service are now properly referencing the master-java21 branch, aligning with the PR objective.

Also applies to: 83-83


218-218: LGTM! Additional services correctly migrated to Java 21 workflows.

The workflow references for esignet-with-plugins, apitest-esignet, and uitest-esignet have been properly updated to use the master-java21 branch.

Also applies to: 241-241, 370-370, 468-468

@sacrana0 sacrana0 closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant