-
Notifications
You must be signed in to change notification settings - Fork 118
MOSIP-44125 - Updated the Apitest commons version to 1.4.0-SNAPSHOT #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
WalkthroughProject version references updated from 1.3.6-SNAPSHOT to 1.4.0-SNAPSHOT across Maven POMs and README dependency examples; artifact filename references adjusted to match the new version. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apitest-commons/pom.xml (1)
70-70: Consider using Maven properties to avoid hardcoding the version string.The
fileNameproperty hardcodes the version, requiring manual updates on every version bump. Instead, leverage Maven's built-in properties for better maintainability and consistency.🔎 Proposed improvement
- <fileName>apitest-commons-1.4.0-SNAPSHOT-jar-with-dependencies</fileName> + <fileName>${project.artifactId}-${project.version}-jar-with-dependencies</fileName>This approach automatically reflects the project version without manual string maintenance, reducing the risk of version drift between the
<version>tag and the filename property.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apitest-commons/pom.xml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-maven-apitest-commons / maven-build
- GitHub Check: build-maven-authentication-demo-service / maven-build
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
apitest-commons/pom.xml (1)
11-11: Version bump correctly applied in both project version and artifact filename.The changes properly update both the project version declaration (line 11) and the generated artifact filename reference (line 70) to consistently reflect the new 1.4.0-SNAPSHOT version.
Also applies to: 70-70
Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(1 hunks)apitest-commons/README.md(1 hunks)pom.xml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-maven-authentication-demo-service / maven-build
- GitHub Check: build-maven-apitest-commons / maven-build
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
apitest-commons/README.md (1)
87-87: Version update is correct and consistent.The version has been updated to 1.4.0-SNAPSHOT across all relevant files: the module's pom.xml, the project root pom.xml, README examples, and build properties. No stale references to the previous 1.3.6-SNAPSHOT version remain.
MOSIP-44125 - Updated the Apitest commons version to 1.4.0-SNAPSHOT
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.