Skip to content

Conversation

@mohanachandran-s
Copy link
Contributor

@mohanachandran-s mohanachandran-s commented Dec 19, 2025

MOSIP-44125 - Updated the Apitest commons version to 1.4.0-SNAPSHOT

Summary by CodeRabbit

  • Chores

    • Bumped project version to 1.4.0-SNAPSHOT across the build configuration.
  • Documentation

    • Updated README usage examples and dependency references to reflect the new 1.4.0-SNAPSHOT version.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Walkthrough

Project version references updated from 1.3.6-SNAPSHOT to 1.4.0-SNAPSHOT across Maven POMs and README dependency examples; artifact filename references adjusted to match the new version.

Changes

Cohort / File(s) Change Summary
Parent/Root POM
pom.xml, mosip-functional-test/pom.xml
Updated project/version property from 1.3.6-SNAPSHOT to 1.4.0-SNAPSHOT.
apitest-commons POM
apitest-commons/pom.xml
Bumped module version to 1.4.0-SNAPSHOT; updated generated artifact filename reference to apitest-commons-1.4.0-SNAPSHOT-jar-with-dependencies.
Documentation / README examples
README.md, apitest-commons/README.md
Updated Maven dependency examples to reference 1.4.0-SNAPSHOT instead of 1.3.6-SNAPSHOT.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to the parent POM version change and any modules relying on the previous version.
  • Verify artifact filename updates where build scripts or CI references the old name.

Suggested reviewers

  • lsivanand

Poem

🐰 A little hop, a small bump in time,
From 1.3.6 to 1.4 I climb,
Snapshots shift and artifacts sing,
New names tucked under my wing. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly and clearly summarizes the main change: updating the Apitest commons version from 1.3.6-SNAPSHOT to 1.4.0-SNAPSHOT, which aligns with all file modifications shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apitest-commons/pom.xml (1)

70-70: Consider using Maven properties to avoid hardcoding the version string.

The fileName property hardcodes the version, requiring manual updates on every version bump. Instead, leverage Maven's built-in properties for better maintainability and consistency.

🔎 Proposed improvement
-		<fileName>apitest-commons-1.4.0-SNAPSHOT-jar-with-dependencies</fileName>
+		<fileName>${project.artifactId}-${project.version}-jar-with-dependencies</fileName>

This approach automatically reflects the project version without manual string maintenance, reducing the risk of version drift between the <version> tag and the filename property.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 385f666 and d3640cd.

📒 Files selected for processing (1)
  • apitest-commons/pom.xml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-maven-apitest-commons / maven-build
  • GitHub Check: build-maven-authentication-demo-service / maven-build
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
apitest-commons/pom.xml (1)

11-11: Version bump correctly applied in both project version and artifact filename.

The changes properly update both the project version declaration (line 11) and the generated artifact filename reference (line 70) to consistently reflect the new 1.4.0-SNAPSHOT version.

Also applies to: 70-70

Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3640cd and d34b574.

📒 Files selected for processing (3)
  • README.md (1 hunks)
  • apitest-commons/README.md (1 hunks)
  • pom.xml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-maven-authentication-demo-service / maven-build
  • GitHub Check: build-maven-apitest-commons / maven-build
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
apitest-commons/README.md (1)

87-87: Version update is correct and consistent.

The version has been updated to 1.4.0-SNAPSHOT across all relevant files: the module's pom.xml, the project root pom.xml, README examples, and build properties. No stale references to the previous 1.3.6-SNAPSHOT version remain.

@mohanachandran-s mohanachandran-s merged commit 6a09d66 into mosip:develop Dec 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant