Skip to content

Conversation

@nihallakshmankonchady
Copy link

No description provided.

Signed-off-by: Nihal LK <nihal.lk@technoforte.co.in>
@nihallakshmankonchady
Copy link
Author

I have added following testcases with their respective csv files.

  1. Create Credential Request
  2. Create Credential Request V2
  3. Get Credential Request
  4. Retrigger Credential Request IDs
  5. Schedule retry Subscription
  6. Schedule retry Subscription
  7. Credential Status update callback
  8. Issue credential
  9. Get credential types

@Sanjayss04
Copy link

In Idrepo Helper Script --> Under Authentication API CredentialReq and CredentialService the varaibles used for client, secret and app id are not in camel case.
Please update.
For eg "CredentialClientId" replace it with "credentialClientId". Follow same for others also.

@Sanjayss04
Copy link

In Idrepo Helper Script --> The sampler doesn't have 2 types of assertion. Only text assertion is present. 200 Response code assertion is not present. Please add.

@Sanjayss04
Copy link

Sanjayss04 commented May 15, 2024

In Idrepo Test Script --> Update the variables to camelCase "CredentialReqAuthToken" and "CredentialServiceAuthToken".

@Sanjayss04
Copy link

Sanjayss04 commented May 15, 2024

In Idrepo Test Script --> Check for the spaces present in the thread group name.
Credential Request(Execution) change to Credential Request (Execution). Check the same for other thread groups also.

Also, check the sampler naming convention at all the places. It must be like "Credential Request Endpoint API".

@Sanjayss04
Copy link

In Idrepo Test Script --> Under Credential Request Generator (Preparation) thread group there is one add identity sampler present which disabled. If not required please remove it from the thread. Check the same at other places too.

Under same thread Load Biometrics Details From File - the csv file path contains absolute path. Please update.

@Sanjayss04
Copy link

In Idrepo Test Script --> Under Credential Request Generator (Preparation) thread group the sampler naming convention is not correct.
Replace "Generate RID" with "Generate RID Endpoint API". Update the same at other places too.

Also, check for the 2 types of assertion. In many samplers only 1 response assertion is added.

Signed-off-by: Nihal LK <nihal.lk@technoforte.co.in>
Copy link
Author

@nihallakshmankonchady nihallakshmankonchady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the scripts as per the review comments.

@Sanjayss04
Copy link

Sanjayss04 commented May 17, 2024

In Idrepo Helper Script --> The sampler doesn't have 2 types of assertion. Only text assertion is present. 200 Response code assertion is not present. Please add.

In idrepo Test Script --> The assertion is named as "Response Assertion 200 response code" and in Helper Script it is named as "Response 200 status code".

Common naming convention must be there. So replace at all the places and please check the same for other scripts too. Replace it with "Response Assertion 200 Response Code"

@Sanjayss04
Copy link

In Idrepo Test Script --> Under Credential Request Generator (Preparation) thread group there is one add identity sampler present which disabled. If not required please remove it from the thread. Check the same at other places too.

Under same thread Load Biometrics Details From File - the csv file path contains absolute path. Please update.

This comment is not fully taken care. I could still see the absolute path.
"Under same thread Load Biometrics Details From File - the csv file path contains absolute path. Please update."

@Sanjayss04
Copy link

In Idrepo Test Script --> Under Credential Request Generator (Preparation) thread group the sampler naming convention is not correct. Replace "Generate RID" with "Generate RID Endpoint API". Update the same at other places too.

Also, check for the 2 types of assertion. In many samplers only 1 response assertion is added.

This comment is not fully taken care.
"Also, check for the 2 types of assertion. In many samplers only 1 response assertion is added."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants