-
Notifications
You must be signed in to change notification settings - Fork 11
PER-47, PER-48, PER-50,PER-51,PER-52,PER-53,PER-54,PER-55 - Credential request and Credential service request #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Nihal LK <nihal.lk@technoforte.co.in>
|
I have added following testcases with their respective csv files.
|
|
In Idrepo Helper Script --> Under Authentication API CredentialReq and CredentialService the varaibles used for client, secret and app id are not in camel case. |
|
In Idrepo Helper Script --> The sampler doesn't have 2 types of assertion. Only text assertion is present. 200 Response code assertion is not present. Please add. |
|
In Idrepo Test Script --> Update the variables to camelCase "CredentialReqAuthToken" and "CredentialServiceAuthToken". |
|
In Idrepo Test Script --> Check for the spaces present in the thread group name. Also, check the sampler naming convention at all the places. It must be like "Credential Request Endpoint API". |
|
In Idrepo Test Script --> Under Credential Request Generator (Preparation) thread group there is one add identity sampler present which disabled. If not required please remove it from the thread. Check the same at other places too. Under same thread Load Biometrics Details From File - the csv file path contains absolute path. Please update. |
|
In Idrepo Test Script --> Under Credential Request Generator (Preparation) thread group the sampler naming convention is not correct. Also, check for the 2 types of assertion. In many samplers only 1 response assertion is added. |
Signed-off-by: Nihal LK <nihal.lk@technoforte.co.in>
nihallakshmankonchady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the scripts as per the review comments.
In idrepo Test Script --> The assertion is named as "Response Assertion 200 response code" and in Helper Script it is named as "Response 200 status code". Common naming convention must be there. So replace at all the places and please check the same for other scripts too. Replace it with "Response Assertion 200 Response Code" |
This comment is not fully taken care. I could still see the absolute path. |
This comment is not fully taken care. |
No description provided.