-
Notifications
You must be signed in to change notification settings - Fork 124
license folder #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license folder #246
Conversation
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
WalkthroughThis PR introduces a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
licenses/NOTICE (1)
35-148: Consider adding missing license files for consistency.The NOTICE file references several licenses that don't have corresponding files in the
licenses/directory:
- ISC License (json-rules-engine, semver, rimraf, lru-cache, yallist, glob)
- 0BSD License (tslib)
- CC-BY-4.0 License (caniuse-lite)
- BSD-2-Clause License (webidl-conversions, normalize-package-data)
While lines 154-161 provide external URLs, consider adding these license files locally for completeness, similar to how MIT.txt and Apache-2.0.txt are included.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
licenses/Apache-2.0.txtlicenses/BSD-3-Clause-No-Nuclear-License.txtlicenses/BSD-3.0.txtlicenses/EPL-1.0.txtlicenses/EPL-2.0.txtlicenses/MIT.txtlicenses/MPL-2.0.txtlicenses/NOTICE
🧰 Additional context used
🪛 LanguageTool
licenses/Apache-2.0.txt
[style] ~51-~51: ‘any and all’ might be wordy. Consider a shorter alternative.
Context: ...ge, computer failure or malfunction, or any and all other commercial damages or losses), ev...
(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
licenses/MPL-2.0.txt
[style] ~47-~47: Consider removing “of” to be more concise
Context: ...tial grant or subsequently, any and all of the rights conveyed by this License. 1.10....
(ALL_OF_THE)
[style] ~106-~106: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...te The licenses granted in Section 2.1 with respect to any Contribution become effective for e...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
[style] ~211-~211: As an alternative to the over-used intensifier ‘absolutely’, consider replacing this phrase.
Context: ...lf of any Contributor. You must make it absolutely clear that any such warranty, support, indemn...
(EN_WEAK_ADJECTIVE)
[style] ~223-~223: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...y with any of the terms of this License with respect to some or all of the Covered Software due...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
[style] ~241-~241: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...non-compliance by some reasonable means prior to 60 days after You have come back into c...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~246-~246: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...h Contributor, and You become compliant prior to 30 days after Your receipt of the notic...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~253-~253: ‘any and all’ might be wordy. Consider a shorter alternative.
Context: ...tent, then the rights granted to You by any and all Contributors for the Covered Software u...
(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
[style] ~258-~258: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...or Your distributors under this License prior to termination shall survive termination. ...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
licenses/EPL-2.0.txt
[style] ~22-~22: Consider a more concise word here.
Context: ...iles of the Program solely in each case in order to link to, bind by name, or subclass the ...
(IN_ORDER_TO_PREMIUM)
[grammar] ~33-~33: Use a hyphen to join words.
Context: ... needed, if any. For example, if a third party patent license is required to allo...
(QB_NEW_EN_HYPHEN)
[style] ~39-~39: Consider replacing this phrase with the adverb “reasonably” to avoid wordiness.
Context: ...and informs Recipients how to obtain it in a reasonable manner on or through a medium customarily used...
(IN_A_X_MANNER)
[style] ~40-~40: Did you mean ‘different from’? ‘Different than’ is often considered colloquial style.
Context: ...e the Program under a license different than this Agreement, provided that such lice...
(DIFFERENT_THAN)
[style] ~52-~52: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...are may accept certain responsibilities with respect to end users, business partners and the li...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
[style] ~52-~52: Consider a more concise word here.
Context: ...ged intellectual property infringement. In order to qualify, an Indemnified Contributor mus...
(IN_ORDER_TO_PREMIUM)
[style] ~69-~69: Consider a more concise word here.
Context: ...istribute copies of this Agreement, but in order to avoid inconsistency the Agreement is co...
(IN_ORDER_TO_PREMIUM)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-pre-registration-ui / npm-build
🔇 Additional comments (4)
licenses/BSD-3.0.txt (1)
1-11: LGTM!Standard BSD-3-Clause license text. The structure and content are correct.
licenses/Apache-2.0.txt (1)
1-73: LGTM!Standard Apache License 2.0 text. The static analysis hint about wordiness should be ignored as this is canonical legal text that must remain unmodified.
licenses/MPL-2.0.txt (1)
1-373: LGTM!Standard Mozilla Public License 2.0 text. The static analysis hints about wordiness should be ignored as this is canonical legal text.
licenses/EPL-2.0.txt (1)
1-80: LGTM!Standard Eclipse Public License 2.0 text. The static analysis hints about wordiness should be ignored as this is canonical legal text.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.