Skip to content

Conversation

@Khuddusshariff0022
Copy link
Contributor

No description provided.

Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
Signed-off-by: khuddus shariff <khuddusshariff0022@gmail.com>
@ashok-ksharma
Copy link
Contributor

ashok-ksharma commented Aug 14, 2025

General comments:

  1. Take care of the spacing in the code for variables for readability purpose.
  2. Try to get the date in LocalDateTime/LocalDate for the date calculation so that we are consistent everywhere.
  3. Try to avoid multiple calling of the getUIN() and getIdJsonFromIDRepo() so that it won't impact the performance.
  4. In newly added/modified method, check whether all the added exception classes are required in throws clause.

To be tested:

  1. Process the NEW packet.
  2. Then process the UPDATE packet for generated UIN.
  3. Then process the LOST/ACTIVATE/DEACTIVATE packer for generated UIN.
  4. packetCreatedOn should be updated for NEW and UPDATE. LOST/ACTIVATE/DEACTIVATE should not remove the packetCreatedOn from IDREPO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants