MOSIP-18889 #2174
Open
MOSIP-18889 #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaledOu <kaled.ouali@gmail.com>
ashok-ksharma
requested changes
Sep 1, 2025
Contributor
There was a problem hiding this comment.
Why we need change in this file. We need to need JUL to SLF4J bridge to be installed before other loggers gets initialized.
Comment on lines
+36
to
+38
| LogManager.getLogManager().reset(); | ||
| SLF4JBridgeHandler.removeHandlersForRootLogger(); | ||
| SLF4JBridgeHandler.install(); |
Contributor
There was a problem hiding this comment.
- Why we need to explicitly install the JUL --> SLF4J bride. How it is different as compared to other apps such as packet manager etc. Why we are not able to see these different format there?
ashok-ksharma
requested changes
Sep 1, 2025
Comment on lines
+25
to
+27
| /** | ||
| * The Constant regProcLogger. | ||
| */ |
Contributor
There was a problem hiding this comment.
Why these unnecessary changes are there ?
Signed-off-by: kaledOu <kaled.ouali@gmail.com>
Signed-off-by: kaledOu <kaled.ouali@gmail.com>
Signed-off-by: kaledOu <kaled.ouali@gmail.com>
Signed-off-by: kaledOu <kaled.ouali@gmail.com>
Signed-off-by: kaledOu <kaled.ouali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.