[unitaryhack] Support arbitrary input sizes in parallel QPIXL decoding#18
Open
rashidraihan wants to merge 2 commits intomoth-quantum:mainfrom
Open
[unitaryhack] Support arbitrary input sizes in parallel QPIXL decoding#18rashidraihan wants to merge 2 commits intomoth-quantum:mainfrom
rashidraihan wants to merge 2 commits intomoth-quantum:mainfrom
Conversation
Contributor
|
Thanks for your submission rashidraihan! The fix works, but sadly someone submitted an equally working fix earlier than you. I hope that our decision is understandable. |
Author
|
Thanks a lot for the update! While I’m a bit sad I wasn’t first, I'm grateful for the opportunity to work on the issue and make my very first contribution. I'm glad my fix was valid. I'll definitely keep an eye out for other opportunities to contribute in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #2
Issue:
The pipeline crashed or distorted images when inputs were sized differently, as the Walsh–Hadamard transform takes power‑of‑2, same vector lengths.
Fix:
pad2d_to_pow2).Followed on 33×40 & 41×34 images; decoded results now exactly like originals with no errors or stripes.