Add progress reporting and retry logic for API requests #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add retry_api_call() helper with exponential backoff for transient failures - Add format_bytes() helper for human-readable download size display - Add retry and max_retries parameters to get_census() - Report download size for data and geometry downloads when quiet=FALSE - Report number of geographic features being processed
Owner
|
Could just wrap into a single parameter, with retry=0 indicating no retries? |
Collaborator
Author
|
I'm fine either way. Main thing I like here is the progress status and giving context on the how much data is being requested and retrieved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
retry_api_call()helper with exponential backoff for transient failuresformat_bytes()helper for human-readable download size displayretryandmax_retriesparameters toget_census()quiet=FALSENew parameters for get_census()
retry(logical): If TRUE, automatically retry failed API requests with exponential backoffmax_retries(integer): Maximum retry attempts (default: 3)Test plan
devtools::check()passes with 0 errors, 0 warnings🤖 Generated with Claude Code