fix: Critical bug fixes and typo corrections #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n daily checks on macos-latest
Bug Fixes: - H2: Fix parenthesis bug in nrow(failed_coordinates) > 0 - H3: Fix "langauge" typo -> "language" in attribute name - H4: Fix duplicated() to catch ALL duplicate headers, not just second occurrence - H6: Fix "_sqlte_fra$" regex typo -> "_sqlite_fra$" - H7: Fix subjectFr using wrong source (subjectEn -> subjectFr) Typo Corrections: - M5: Fix "Unkown" -> "Unknown" (4 occurrences) - M6: Fix "gplimpse" -> "glimpse" in documentation - M7: Fix "failty" -> "faulty" in error messages (2 occurrences) - L4: Fix "pr" -> "or" in roxygen documentation - L5: Remove redundant (strip_classification_code) in param docs Closes #145, #147 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical bugs and typos identified in the code audit.
Bug Fixes
nrow(failed_coordinates > 0)→nrow(failed_coordinates) > 0"langauge"→"language"_sqlte_fra$→_sqlite_fra$subjects$subjectEn→subjects$subjectFrTypo Corrections
(strip_classification_code)Testing
Related Issues
Closes #145, #147
🤖 Generated with Claude Code