-
Notifications
You must be signed in to change notification settings - Fork 7
Epic / Locatability #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dncsvr
wants to merge
64
commits into
main
Choose a base branch
from
epic/locatability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Epic / Locatability #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove identity configuration from `AutoMap` feature
- remove `GuidIdAsIdentity` coding style feature - update documentation
- add `Type` and `Key` properties to IdAttribute - add type and idSuffix parameters to `ConvertToId` helpers
- use `Id` in entities
- add json converter for Id - add schema filter for Id - move id tests to Id feature folder
- ignore `RoutingEntitySubclasses` tests
- add `IdAttribute` convention to `RichTransient` feature
- change Id to record struct and make constructor private - improve GuidIdUserType - add test for `Id`
- remove TODO comments from GuidIdUserType
- add `TryGetıdentifier` extension for TypeModel and return `IdentifierInfo` - rename `Id` attribute to `Identifier` - refactor features and conventions
- add `UserTypeBase` abstract class
- rename feature to `IdentifierMapping`
- rename AddId to AddIdentifierMapping
- move id json converter to coding style feature
- move feature to `CodingStyle` and name it as `Id` - move `IdAttribute` type to `Business` feature - update documentation
- rename IdentifierInfo to IdInfo - move GetIdInfo helpers to Business feature
- change GuidIdGenerator to extend GuidGenerator - remove TypeCheck from GuidIdUserType
- change `ConvertToId` to use `IdInfo` as parameter
- rename `GuidId` to `IdGuid` - use Parse instead of TryParse in user type - remove empty lines - remove unnecessary Kebaberize
- improve Id coding style documentation - update auto map orm feature documentation - update unreleased
- restrict to Id typed properties as well as Id named properties - update rich transient samples to use `Business.Id`
- move id tests to coding style folder - validate identifier generator type
- rename `IdInfo.Name` to `IdInfo.PropertyName` - use explicit Camelize for target name
- change id type of sample records to `Id` - minor format edits
- minor format edits
- move TryGetIdInfo above
- refactor Guid id tests assertion - minor format edits
- update Id coding style documentation
- update id coding style entity sample documentation
- move global usings to their own template file
- refactor IdMapperTemplate into single file
- fix format
…on-as-feature Issue / Locatability / ID Configuration As Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve domain objects locating in baked.
Tasks
serializing serialize as is. when deserializing expect only id
{ "entity": { "id": "123" } }prop: { id: ... }, so consider creatingan object ref dto
and is only proxy with id
entityId=(it probably already is)idis used as an example, it should use whatever prop name is the domainobject's id prop. if it is
Uidit should be/{uid},entityUid=and{ "uid": ... }in route, query and body respectivelyOrmConfig Ormto improve design, currently it seems irrelevantIddesignId.Parse(3)-> this is not parsing ->Id.Create(3)id.IsEmptyandId.Emptyrespectively
RotingEntitySubclassesfixtureSingleByUniqueAttirbuteand fix buildAdditional Tasks