Catalist: Patch Exception Handling

[IanRFerguson]

What is this change?

Adds an exception for clarity in the CatalistMatch class if there is a failure to save the zipped file from the vendor's SFTP server. The current active exception is raising on zf.extractall(path=temp_dir), which tells us there's a problem with the file but not much else.

Breaking changes (if needed)

This is not a breaking change.

Considerations for discussion

N/A

How to test the changes (if needed)

• (How should a reviewer test this functionality.)

Labels

Please add exactly one of the following labels to this PR:

• breaking-change — This PR introduces a breaking change to the public API
• non-breaking-change — This PR does not break any existing functionality

The label check CI job will fail until one of these labels is applied.

[bmos]

In case it helps, here are rebuilt tests that actually use real files.
ian/patch/catalist-zip-operation...bmos:parsons:catalist-testing

[IanRFerguson]

In case it helps, here are rebuilt tests that actually use real files. ian/patch/catalist-zip-operation...bmos:parsons:catalist-testing

awesome, appreciate you Ramona! looks like everything besides the label check was passing (and I've since fixed that)

should I merge your branch into this one? or what's the standard operating procedure?

[bmos]

Merging it before merging this one is probably better in theory because it shows that the tests pass with the existing code, but I'd suggest you just merge it into your branch for simplicity because of the limited scope of this PR and knowing that I did run those tests without the changes in this PR. I'm fine with either and will be doing PR reviews with @shaunagm this afternoon if it's preferred to handle them separately.

[shaunagm]

approved and happy to merge once the tests pass (I assume they're not failing from this and the PR just needs to be updated)

[bmos]

They won't pass, the test suite needs to be changed.
There's a PR for @IanRFerguson to merge into this.
I'm going to post the PR against main since the test improvements are technically separate.

[shaunagm]

oh gotcha. i'll wait then!