Skip to content

Email / Gmail / SMTP Updates#1822

Open
bmos wants to merge 35 commits intomove-coop:mainfrom
bmos:email_module_updates
Open

Email / Gmail / SMTP Updates#1822
bmos wants to merge 35 commits intomove-coop:mainfrom
bmos:email_module_updates

Conversation

@bmos
Copy link
Copy Markdown
Collaborator

@bmos bmos commented Apr 10, 2026

What is this change?

  • Refactor email tests to use parameterized pytest format.
  • Increase test coverage of email functionality.
  • Add mocked tests for gmail sending functionality.
  • Add support for SMTP_SSL.
  • Infer SMTP port based on security protocol in use.
  • Add SMTP.quit method for manually closing active connection.
  • Remove BCC values from email header for privacy

How to test the changes (if needed)

  • CI Tests should be adequate

Breaking Changes

Breaking changes are changes to our public API which may require existing users to change their code. If there are no breaking changes, any existing parsons user should not need to do anything after updating their parsons version.

Does this PR introduce breaking changes?
  • label: Breaking change — This PR introduces one or more breaking changes.
  • label: Non-breaking change — This PR does not introduce one or more breaking changes.

Details (if needed)

  • (List out any changes to the API that may cause breaks for developer implementation.)

@github-actions github-actions bot added non-breaking-change Status - Indicates that the code in this PR does not have any breaking changes. testing Work type - writing or changing code tests for core Parsons features or Parsons connectors python Pull requests that update Python code and removed non-breaking-change Status - Indicates that the code in this PR does not have any breaking changes. labels Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  parsons/notifications
  gmail.py
  sendmail.py 53
  smtp.py 91, 96-98, 123, 127-128, 138-141
Project Total  

This report was generated by python-coverage-comment-action

@bmos bmos force-pushed the email_module_updates branch from 3801015 to f5e41ee Compare April 10, 2026 20:29
Comment thread test/test_gmail/test_gmail.py Fixed
Comment thread test/test_gmail/test_gmail.py Fixed
Comment thread test/test_gmail/test_gmail.py Fixed
@bmos bmos force-pushed the email_module_updates branch from 5d48913 to 7212905 Compare April 10, 2026 20:53
Comment thread test/test_gmail/test_gmail.py Fixed
Comment thread test/test_gmail/test_gmail.py Fixed
reverts 41b9ab2
and reimplements for new test structures
@bmos bmos force-pushed the email_module_updates branch from 7212905 to e159131 Compare April 10, 2026 20:54
@bmos bmos marked this pull request as ready for review April 11, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-breaking-change Status - Indicates that the code in this PR does not have any breaking changes. python Pull requests that update Python code testing Work type - writing or changing code tests for core Parsons features or Parsons connectors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants