Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ros2 #266 +/- ##
==========================================
- Coverage 69.06% 69.04% -0.01%
==========================================
Files 21 21
Lines 3370 3368 -2
Branches 325 325
==========================================
- Hits 2327 2325 -2
Misses 932 932
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhaschke
left a comment
There was a problem hiding this comment.
While this is a quick fix, geometric_shapes doesn't directly depend on Boost::random:
$ grep -r "boost/"
test/test_ray_intersection.cpp:#include <boost/filesystem.hpp>
test/test_loaded_meshes.cpp:#include <boost/filesystem.hpp>
test/test_bounding_sphere.cpp:#include <boost/filesystem.hpp>
test/test_point_inclusion.cpp:#include <boost/filesystem.hpp>
test/test_body_operations.cpp:#include <boost/filesystem.hpp>
include/geometric_shapes/shape_messages.h:#include <boost/variant.hpp>
src/mesh_operations.cpp:#include <boost/math/constants/constants.hpp>
src/bodies.cpp:#include <boost/math/constants/constants.hpp>
Rather, random_numbers should pull in that dependency in a transitive fashion.
I'm surprised that this is not yet working as random_numbers correctly declares the dependency:
find_package(Boost REQUIRED COMPONENTS random)
Ah. The reason is that the referenced buildfarm build uses an outdated version of Hence, you should check why the buildfarm uses an outdated version. |
|
Looks like you found the issue - the build succeeded now. |
|
The package was not rebuild with the new |
Related to https://build.ros2.org/view/Rdev/job/Rdev__geometric_shapes__ubuntu_noble_amd64/18/console#console-section-3