Skip to content

Fixed CMakeLists.txt: Boost random#266

Closed
ahcorde wants to merge 1 commit intomoveit:ros2from
ahcorde:ahcorde/rolling/fix_cmake
Closed

Fixed CMakeLists.txt: Boost random#266
ahcorde wants to merge 1 commit intomoveit:ros2from
ahcorde:ahcorde/rolling/fix_cmake

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Jan 14, 2026

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.04%. Comparing base (59671b8) to head (76896b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             ros2     #266      +/-   ##
==========================================
- Coverage   69.06%   69.04%   -0.01%     
==========================================
  Files          21       21              
  Lines        3370     3368       -2     
  Branches      325      325              
==========================================
- Hits         2327     2325       -2     
  Misses        932      932              
  Partials      111      111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a quick fix, geometric_shapes doesn't directly depend on Boost::random:

$ grep -r "boost/"
test/test_ray_intersection.cpp:#include <boost/filesystem.hpp>
test/test_loaded_meshes.cpp:#include <boost/filesystem.hpp>
test/test_bounding_sphere.cpp:#include <boost/filesystem.hpp>
test/test_point_inclusion.cpp:#include <boost/filesystem.hpp>
test/test_body_operations.cpp:#include <boost/filesystem.hpp>
include/geometric_shapes/shape_messages.h:#include <boost/variant.hpp>
src/mesh_operations.cpp:#include <boost/math/constants/constants.hpp>
src/bodies.cpp:#include <boost/math/constants/constants.hpp>

Rather, random_numbers should pull in that dependency in a transitive fashion.
I'm surprised that this is not yet working as random_numbers correctly declares the dependency:

find_package(Boost REQUIRED COMPONENTS random)

@rhaschke
Copy link
Copy Markdown
Contributor

I'm surprised that this is not yet working as random_numbers correctly declares the dependency.

Ah. The reason is that the referenced buildfarm build uses an outdated version of random_numbers (2.0.2 instead of 2.0.4):

$ apt policy ros-rolling-random-numbers
ros-rolling-random-numbers:
  Installed: (none)
  Candidate: 2.0.4-1noble.20250730.134617
  Version table:
     2.0.4-1noble.20250730.134617 500
        500 http://packages.ros.org/ros2/ubuntu noble/main amd64 Packages

Hence, you should check why the buildfarm uses an outdated version.

@rhaschke
Copy link
Copy Markdown
Contributor

Looks like you found the issue - the build succeeded now.
What was the reason for the outdated random_numbers package?

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Jan 15, 2026

The package was not rebuild with the new random_number release

@ahcorde ahcorde closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants