Initialize the namespace property for custom iMarkers in rviz (backport #3547)#3551
Open
mergify[bot] wants to merge 1 commit intojazzyfrom
Open
Initialize the namespace property for custom iMarkers in rviz (backport #3547)#3551mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
(cherry picked from commit 3e526af)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jazzy #3551 +/- ##
==========================================
- Coverage 46.21% 46.20% -0.00%
==========================================
Files 718 718
Lines 62675 62679 +4
Branches 7589 7590 +1
==========================================
- Hits 28957 28953 -4
- Misses 33554 33559 +5
- Partials 164 167 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MatthijsBurgh
approved these changes
Sep 30, 2025
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MoveIt's iMarker doesn't initialize the marker namespace property, so that functionality is broken when you try to add other iMarkers alongside moveit's planning interface. Normally this just breaks the cursor, though in some cases we've seen rviz crash. I was under the impression that pluginlib might still load the default plugin for other markers, but that does not seem to be the case.
Regardless, I don't think there's a downside to providing the node abstraction to the namespace property object, so this PR just uncomments those lines.
Before (cursor gets stuck as a spinning wheel):
Screen.Recording.2025-08-09.at.10.47.21.AM.mov
After:
Screen.Recording.2025-08-09.at.10.49.49.AM.mov
Checklist
This is an automatic backport of pull request #3547 done by [Mergify](https://mergify.com).