Fix severe warning from class loader in servo (backport #3577)#3597
Draft
mergify[bot] wants to merge 1 commit intohumblefrom
Draft
Fix severe warning from class loader in servo (backport #3577)#3597mergify[bot] wants to merge 1 commit intohumblefrom
mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
* Add class loader member variable instead of creating on stack * Fix formatting to satisfy clang --------- Co-authored-by: AndyZe <andyz@utexas.edu> Co-authored-by: Nathan Brooks <nathanbrooks@picknik.ai> (cherry picked from commit 92654dd) # Conflicts: # moveit_ros/moveit_servo/include/moveit_servo/servo.hpp # moveit_ros/moveit_servo/src/servo.cpp
Author
|
Cherry-pick of 92654dd has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
@AndyZe please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix "SEVERE WARNING" from class loader in moveit_servo, created the class loader as a member variable instead of creating it on the stack.
This fixes the following error:
This is an automatic backport of pull request #3577 done by [Mergify](https://mergify.com).