Feature/make use of max cartesian speed in MotionPlanRequest with pilz planner#3608
Closed
AimanHaidar wants to merge 4 commits intomoveit:mainfrom
Closed
Feature/make use of max cartesian speed in MotionPlanRequest with pilz planner#3608AimanHaidar wants to merge 4 commits intomoveit:mainfrom
AimanHaidar wants to merge 4 commits intomoveit:mainfrom
Conversation
Contributor
Author
|
I will close this because it is now included in #3610 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request make use of the
max_cartesian_speedfield in theMotionPlanRequestbecause I noticed it is not useful for the Pilz planner.Currently, the planner always uses the value from
pilz_cartesian_limits.yaml(loaded toplanner_limits_) and does not make use of themax_cartesian_speedspecified in the request. Moreover, setting these limits dynamically withdoes not update the planner behavior as expected.
This PR introduces a small change to apply the
max_cartesian_speedvalue from the request item when planning the trajectory, instead of always relying on the static configuration fromplanner_limits_.As a result, users can now specify Cartesian speed limit directly in their MotionPlanRequest, and seems to be related to moveit issues issue1 and issue2.
I don't know if my way of coding is good for the planner, since I didn't make use of
cartesian_speed_limited_linkfieldExample
Below is an example of a sequence request containing three planning items, each with different
max_cartesian_speedvalues applied correctly after this PR:Checklist