fix segfault when planning with differential drive planar joint#3659
Open
jsupratman13 wants to merge 3 commits intomoveit:mainfrom
Open
fix segfault when planning with differential drive planar joint#3659jsupratman13 wants to merge 3 commits intomoveit:mainfrom
jsupratman13 wants to merge 3 commits intomoveit:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 46.23% 46.30% +0.08%
==========================================
Files 726 726
Lines 59484 59497 +13
Branches 7625 7629 +4
==========================================
+ Hits 27495 27544 +49
+ Misses 31822 31786 -36
Partials 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0dd4539 to
0333cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI seem to be failing becauseros-rolling-picknik-reset-fault-controlleris not found, but it looks like this was fixed in Build failure on ROS 2 Rolling Buildfarm PickNikRobotics/picknik_controllers#22. I assume this will be restored in the next rolling sync. Not sure if I should keep the PR open or convert to draft until ci issue is fixed Keeping this PR on draft until next rolling syncChecklist