Use moveit_configs_utils for launch files#365
Merged
JafarAbdi merged 5 commits intomoveit:ros2from May 26, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## ros2 #365 +/- ##
=======================================
Coverage 38.85% 38.85%
=======================================
Files 78 78
Lines 7520 7520
=======================================
Hits 2921 2921
Misses 4599 4599 Continue to review full report at Codecov.
|
Contributor
stephanie-eng
left a comment
stephanie-eng
left a comment
There was a problem hiding this comment.
I found a few imports I think we can clean up
stephanie-eng
approved these changes
May 25, 2022
Contributor
stephanie-eng
left a comment
stephanie-eng
left a comment
There was a problem hiding this comment.
Sorry about the above mix-up, tested with the the two PR's you linked and all works!
henningkayser
approved these changes
May 26, 2022
Member
henningkayser
left a comment
henningkayser
left a comment
There was a problem hiding this comment.
This is such a huge improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: you need moveit/moveit2#1274 and PickNikRobotics/rosparam_shortcuts#27 to be able to run the demos