separate collision_object creation from publishing#55
separate collision_object creation from publishing#55mlautman wants to merge 2 commits intomoveit:masterfrom
Conversation
davetcoleman
left a comment
davetcoleman
left a comment
There was a problem hiding this comment.
Thanks for making this more general!
| * \return true on sucess | ||
| **/ | ||
| moveit_msgs::CollisionObject createCollisionBlock(const geometry_msgs::Pose& block_pose, const std::string& name, | ||
| double block_size); |
There was a problem hiding this comment.
is it possible for the CollisionObject msgs type to support color as well?
There was a problem hiding this comment.
we would have to change the msg
| * \brief Create/Publish a MoveIt Collision block at the given pose | ||
| * \param pose - location of center of block | ||
| * \param name - semantic name of MoveIt collision object | ||
| * \param size - height=width=depth=size |
|
|
||
| /** | ||
| * \brief Create a MoveIt Collision block at the given pose | ||
| * \brief Create/Publish a MoveIt Collision block at the given pose |
There was a problem hiding this comment.
i'd rather you copy this doxygen for reach function. it seems these two functions due fairly different things, and the \brief should explain that difference better.
| /** | ||
| * \brief Create a MoveIt Collision block at the given pose | ||
| * \brief Create/Publish a MoveIt Collision block at the given pose | ||
| * \param pose - location of center of block |
| * \param color to display the collision object with | ||
| * \return true on sucess | ||
| **/ | ||
| moveit_msgs::CollisionObject createCollisionObject(const Eigen::Vector3d& point1, const Eigen::Vector3d& point2, |
There was a problem hiding this comment.
this should be createCollisionCuboid right? Even better: createCollisionCuboidMsg
| * \param color to display the collision object with | ||
| * \return true on sucess | ||
| **/ | ||
| moveit_msgs::CollisionObject createCollisionObject(const Eigen::Isometry3d& pose, double width, double depth, |
There was a problem hiding this comment.
same comments:
rename function to include Cuboid
src/moveit_visual_tools.cpp
Outdated
| double depth, double height, | ||
| const std::string& name) | ||
| { | ||
| geometry_msgs::Pose pose_msg = tf2::toMsg(pose); |
There was a problem hiding this comment.
typically in *_visual_tools, we use the built-in converter helper function rather than tf2, could you use that? e.g. convertPose()
same below
mlautman
force-pushed
the
create-and-pub-separately
branch
2 times, most recently
from
e626338 to
6c354a5
Compare
mlautman
force-pushed
the
create-and-pub-separately
branch
from
6c354a5 to
b274866
Compare
|
@davetcoleman Done |
|
Ive just retriggered travis, but i think you need to rebase on master with the travis fix you just made? |
2 participants
Git seems to have messed up the diff. Any suggestions to avoid this?