Skip to content

Add Movement Ops Changes#18

Open
Primata wants to merge 9 commits intomainfrom
movement-ops
Open

Add Movement Ops Changes#18
Primata wants to merge 9 commits intomainfrom
movement-ops

Conversation

@Primata
Copy link
Copy Markdown
Collaborator

@Primata Primata commented Mar 24, 2026

  • scripts to handle deployment and configuration of OFTs
  • environment configuration according to cli and profile
  • propose multisig upgrade tx
  • oft_fa v2

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Primata and others added 2 commits March 24, 2026 00:57
Co-authored-by: Andy Golay <andygolay@gmail.com>
Copy link
Copy Markdown
Collaborator

@andygolay andygolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't check deploy.sh, config.sh, encode_configs.sh or set_move_env.sh so please double check all that before using. Otherwise LGTM, unit tests for oft_fa.move pass.

[dependencies.AptosFramework]
git = "https://github.com/aptos-labs/aptos-framework.git"
rev = "mainnet"
rev = "99f5e915b6d231d0ffbc1aff282d36148d2a8b24"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why choose this commit aptos-labs/aptos-framework@99f5e91?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me revert this

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygolay are we using mainnet or m1 nomeclature?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

set -u
# Exit on pipe failures
set -o pipefail
cli="aptos"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be movement? This script is using a mix of movement and aptos

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use whatever, it depends on what you want. I used this to deploy GUI adapter on aptos, that's why it's currently aptos, but it's up to the user to use the correct cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants