uplifts: allow uplift requests before landing on autoland (Bug 2030756)#1071
Closed
cgsheeh wants to merge 5 commits intomozilla-conduit:mainfrom
Closed
uplifts: allow uplift requests before landing on autoland (Bug 2030756)#1071cgsheeh wants to merge 5 commits intomozilla-conduit:mainfrom
cgsheeh wants to merge 5 commits intomozilla-conduit:mainfrom
Conversation
Previously, requesting an uplift required the patch to have already landed on autoland so that Lando had a `Revision` record with patch data. This blocked sec-related uplifts where developers had to wait for sec-approval before landing on autoland, and only then could request the uplift. Now, when an uplift request is submitted, Lando fetches the revision and diff data directly from Phabricator for any revisions that don't already exist in the database. This happens inside the `UpliftRequestForm` before validation, so the rest of the flow works unchanged. The `Revision` creation logic from the landing POST endpoint has been extracted into reusable helpers (`save_revision_patch_data` and `ensure_revision_from_phabricator`) that both the landing and uplift flows now share.
|
View this pull request in Lando to land it once approved. |
shtrom
approved these changes
Apr 13, 2026
lando-worker bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
…6) r=shtrom Previously, requesting an uplift required the patch to have already landed on autoland so that Lando had a `Revision` record with patch data. This blocked sec-related uplifts where developers had to wait for sec-approval before landing on autoland, and only then could request the uplift. Now, when an uplift request is submitted, Lando fetches the revision and diff data directly from Phabricator for any revisions that don't already exist in the database. The `Revision` creation logic from the landing POST endpoint has been extracted into reusable helpers that both the landing and uplift flows now share. Pull request: #1071
|
Pull request closed by commit d352091 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, requesting an uplift required the patch to have already
landed on autoland so that Lando had a
Revisionrecord with patchdata. This blocked sec-related uplifts where developers had to wait
for sec-approval before landing on autoland, and only then could
request the uplift.
Now, when an uplift request is submitted, Lando fetches the revision
and diff data directly from Phabricator for any revisions that don't
already exist in the database.
The
Revisioncreation logic from the landing POST endpoint has beenextracted into reusable helpers that both the landing and uplift
flows now share.