Skip to content

add GCP token file to dockerignore#1031

Merged
robhudson merged 1 commit intomozilla-it:mainfrom
runo721:runo721-patch-1
Apr 10, 2025
Merged

add GCP token file to dockerignore#1031
robhudson merged 1 commit intomozilla-it:mainfrom
runo721:runo721-patch-1

Conversation

@runo721
Copy link
Copy Markdown
Contributor

@runo721 runo721 commented Apr 9, 2025

No description provided.

@runo721 runo721 requested a review from a team as a code owner April 9, 2025 17:46
@robhudson
Copy link
Copy Markdown
Contributor

Just confirming this aligns with these other commits and I'm assuming it's related to the same or similar issue:

@fkiriakos07
Copy link
Copy Markdown

Hello @robhudson , yes correct, this is an additional mitigation to prevent gcp credentials from being included in the docker image. Thanks.

@robhudson robhudson added the docker Pull requests that update Docker code label Apr 10, 2025
@robhudson robhudson merged commit 6d4cf1e into mozilla-it:main Apr 10, 2025
5 of 6 checks passed
@leplatrem
Copy link
Copy Markdown
Contributor

Related: mozilla/remote-settings@41d2c50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Pull requests that update Docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants