Skip to content

chore: add redirection for datacollective.mozillafoundation.org sites#429

Merged
bqbn merged 2 commits intomainfrom
svcse-4369
Apr 2, 2026
Merged

chore: add redirection for datacollective.mozillafoundation.org sites#429
bqbn merged 2 commits intomainfrom
svcse-4369

Conversation

@bqbn
Copy link
Copy Markdown
Contributor

@bqbn bqbn commented Apr 1, 2026

Refractr PR Checklist

JIRA ticket: https://mozilla-hub.atlassian.net/browse/SVCSE-4369

When creating a PR for Refractr, confirm you've done the following steps for a smooth CI and CD experience:

  • Have you updated the relevant YAML in the PR?
  • Have you checked the relevant YAML for any possible dupes regarding your domain?
  • Have you checked if there are any TLS cert concerns - e.g. if the domain being redirected already exists, and it is being changed to point at refractr, is a temporary TLS 'outage' while waiting for certification via HTTP challenge okay? If not, add a note to the JIRA ticket.
  • If desired, have you generated the nginx config manually to confirm updates work as expected?

@bqbn bqbn requested review from a team as code owners April 1, 2026 22:54
@bqbn bqbn requested a review from whd April 1, 2026 23:25
Copy link
Copy Markdown
Contributor

@whd whd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original request asks for resolving paths as well. That's something refractr appears to accomodate and so does our cert generation logic.

So pattern matching on careers.mozilla.org as an example:

- dsts:
  - if: '$request_uri ~ ^/(.*)$'
    ^/(.*)$: www.mozilla.org/careers/$1
  - redirect: www.mozilla.org/careers/
  srcs:
  - careers.mozilla.org
  tests:
  - https://careers.mozilla.org/: https://www.mozilla.org/careers/
  # - https://careers.mozilla.org/#locations: https://www.mozilla.org/careers/#locations
  - https://careers.mozilla.org/listings: https://www.mozilla.org/careers/listings
  - https://careers.mozilla.org/listings/: https://www.mozilla.org/careers/listings/
  - https://careers.mozilla.org/feed/: https://www.mozilla.org/careers/feed/
  - https://careers.mozilla.org/position/gh/12345/: https://www.mozilla.org/careers/position/gh/12345/

I think we can accommodate the request via:

# SVCSE-4369
- dsts:
  - if: '$request_uri ~ ^/(.*)$'
    ^/(.*)$: mozilladatacollective.com/$1
  - redirect: mozilladatacollective.com/
  srcs:
  - datacollective.mozillafoundation.org
  - dev.datacollective.mozillafoundation.org
  tests:
  - https://datacollective.mozillafoundation.org/: https://mozilladatacollective.com/
  - https://datacollective.mozillafoundation.org/datasets/abc123: https://mozilladatacollective.com/datasets/abc123
  - https://datacollective.mozillafoundation.org/datasets/: https://mozilladatacollective.com/datasets/
  - https://dev.datacollective.mozillafoundation.org/: https://mozilladatacollective.com/
  - https://dev.datacollective.mozillafoundation.org/datasets/abc123: https://mozilladatacollective.com/datasets/abc123

Though I've never done this before.

I see from git history @bkochendorfer has made several srcs type changes so I'll request a review from him in case I'm missing something.

@whd whd requested a review from bkochendorfer April 2, 2026 00:00
@bqbn
Copy link
Copy Markdown
Contributor Author

bqbn commented Apr 2, 2026

Made the change as suggested. Thank you!

@bqbn bqbn merged commit 15ea9ab into main Apr 2, 2026
1 check passed
@bqbn bqbn deleted the svcse-4369 branch April 2, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants