Skip to content

Conversation

@eemeli
Copy link
Member

@eemeli eemeli commented Oct 3, 2025

Filed initially as draft, as this depends on https://phabricator.services.mozilla.com/D266753 landing first. The searchfox links don't work yet.

Co-authored-by: Bryan Olsson <bolsson@mozilla.com>
Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure these instructions belong to the beta/release step, some of these are basic needs to get usable builds (e.g. accept-languages, fonts), so they should be set up when nightly builds are enabled?

eemeli and others added 2 commits October 7, 2025 15:32
@eemeli
Copy link
Member Author

eemeli commented Oct 7, 2025

I am not sure these instructions belong to the beta/release step, some of these are basic needs to get usable builds (e.g. accept-languages, fonts), so they should be set up when nightly builds are enabled?

The default values for these are fine for getting started. For a new locale foo-FI, accept-languages defaults to foo-FI, foo, en-US, en and font language group defaults to x-western. I should actually check if the fonts could be selected based on the locale's script, that ought to reduce the number of special cases quite a bit...

@eemeli
Copy link
Member Author

eemeli commented Nov 24, 2025

As the Firefox change landed, this is good to review & merge.

@eemeli eemeli marked this pull request as ready for review November 24, 2025 11:03
@eemeli eemeli requested a review from a team as a code owner November 24, 2025 11:03
If you know that users of your locale would prefer a different variety of English,
or if they are not likely to understand English at all,
you may opt to include a different English language tag,
or to exclude English altogether.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we suggest excluding English completely? I feel like having a likely fallback is not a bad thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention the possibility. If someone does request that, it'll get discussed in any case.

@flodolo flodolo requested a review from bcolsson November 24, 2025 13:30
Co-authored-by: Francesco Lodolo <flod@lodolo.net>
@eemeli eemeli merged commit 83d43f1 into main Nov 26, 2025
2 checks passed
@eemeli eemeli deleted the firefox-localized-prefs branch November 26, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants