-
Notifications
You must be signed in to change notification settings - Fork 21
Add section on updated locale-specific settings for Firefox Desktop #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Bryan Olsson <bolsson@mozilla.com>
flodolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure these instructions belong to the beta/release step, some of these are basic needs to get usable builds (e.g. accept-languages, fonts), so they should be set up when nightly builds are enabled?
Co-authored-by: Francesco Lodolo <flod@lodolo.net>
The default values for these are fine for getting started. For a new locale |
|
As the Firefox change landed, this is good to review & merge. |
| If you know that users of your locale would prefer a different variety of English, | ||
| or if they are not likely to understand English at all, | ||
| you may opt to include a different English language tag, | ||
| or to exclude English altogether. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we suggest excluding English completely? I feel like having a likely fallback is not a bad thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention the possibility. If someone does request that, it'll get discussed in any case.
Co-authored-by: Francesco Lodolo <flod@lodolo.net>
Filed initially as draft, as this depends on https://phabricator.services.mozilla.com/D266753 landing first. The searchfox links don't work yet.