Conversation
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 89.3% 87.73% -1.58%
==========================================
Files 7 7
Lines 823 848 +25
==========================================
+ Hits 735 744 +9
- Misses 88 104 +16
Continue to review full report at Codecov.
|
oremj
left a comment
There was a problem hiding this comment.
Can we look into logging these in JSON format?
oremj
left a comment
There was a problem hiding this comment.
I think we should either do it like this: https://docs.python.org/3/howto/logging-cookbook.html#implementing-structured-logging or you could look in to a package like https://github.com/hynek/structlog
jbuck
left a comment
There was a problem hiding this comment.
Rather than rolling your own structured logger, I think it'd make more sense to use an existing one like the built-in Flask logger or structlog
PR is dependant on #33