Skip to content
This repository was archived by the owner on Mar 28, 2019. It is now read-only.

Remove backward incompatibilities regarding Enums#663

Merged
Natim merged 2 commits intomasterfrom
avoid-backward-incompability
Feb 23, 2016
Merged

Remove backward incompatibilities regarding Enums#663
Natim merged 2 commits intomasterfrom
avoid-backward-incompability

Conversation

@leplatrem
Copy link
Copy Markdown
Contributor

BC had been introduced in #652

  • Use COMPARISON Enum as constants instead of values
  • Use Enum in event subscriber predicate

@Natim
Copy link
Copy Markdown
Contributor

Natim commented Feb 23, 2016

r+

@almet
Copy link
Copy Markdown
Contributor

almet commented Feb 23, 2016

Looks good to me!

Natim added a commit that referenced this pull request Feb 23, 2016
…ility

Remove backward incompatibilities regarding Enums
@Natim Natim merged commit aaf1141 into master Feb 23, 2016
@Natim Natim deleted the avoid-backward-incompability branch February 23, 2016 10:13
@Natim Natim removed the in progress label Feb 23, 2016
@leplatrem leplatrem modified the milestone: 3.0.0 Feb 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants