Skip to content

SYNC-5167: Errors only dashboards #7181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bendk wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −112
Open

SYNC-5167: Errors only dashboards #7181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/generate-rust-dashboards/src/metrics/rust_component_errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ pub fn add_to_dashboard(builder: &mut DashboardBuilder, config: &TeamConfig) ->
builder.add_panel_title("Component Errors");

for app in config.applications().iter() {
// Errors are only implemented on Android at this point.
if *app != Application::Android {
continue;
}
builder.add_panel_third(count_panel(config, *app, ReleaseChannel::Nightly));
builder.add_panel_third(count_panel(config, *app, ReleaseChannel::Beta));
builder.add_panel_third(count_panel(config, *app, ReleaseChannel::Release));
Expand Down
118 changes: 6 additions & 112 deletions tools/generate-rust-dashboards/src/team_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

use crate::config::*;

use Application::*;

pub fn all_dashboards() -> Vec<TeamConfig> {
vec![
TeamConfig {
Expand All @@ -19,128 +17,24 @@ pub fn all_dashboards() -> Vec<TeamConfig> {
Component::Tabs,
],
component_errors: true,
sync_metrics: true,
main_dashboard_metrics: vec![DistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Places run_maintenance() time",
ping: "metrics",
category: "places_manager",
metric: "run_maintenance_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: None,
applications: vec![Android],
link_to: Some("Sync Maintenance Times"),
}
.into()],
extra_dashboards: vec![ExtraDashboard {
name: "Sync Maintenance Times",
metrics: vec![
DistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Places run_maintenance_chk_pnt_time() time",
ping: "metrics",
category: "places_manager",
metric: "run_maintenance_chk_pnt_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: None,
applications: vec![Android],
link_to: None,
}
.into(),
DistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Places run_maintenance_optimize_time() time",
ping: "metrics",
category: "places_manager",
metric: "run_maintenance_optimize_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: None,
applications: vec![Android],
link_to: None,
}
.into(),
DistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Places run_maintenance_prune_time() time",
ping: "metrics",
category: "places_manager",
metric: "run_maintenance_prune_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: None,
applications: vec![Android],
link_to: None,
}
.into(),
DistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Places run_maintenance_vacuum_time() time",
ping: "metrics",
category: "places_manager",
metric: "run_maintenance_vacuum_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: None,
applications: vec![Android],
link_to: None,
}
.into(),
],
}],
// Metrics aren't supported yet. Keep the following fields false/empty for now.
sync_metrics: false,
main_dashboard_metrics: vec![],
extra_dashboards: vec![],
},
TeamConfig {
team_name: "DISCO",
components: vec![Component::Suggest],
component_errors: true,
sync_metrics: false,
main_dashboard_metrics: vec![
LabeledDistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Suggest ingest time",
ping: "metrics",
category: "suggest",
metric: "ingest_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: Some(100_000),
applications: vec![Desktop],
}
.into(),
LabeledDistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Suggest ingest download time",
ping: "metrics",
category: "suggest",
metric: "ingest_download_time",
axis_label: "time (ms)",
value_divisor: Some(1_000_000),
value_filter: None,
applications: vec![Desktop],
}
.into(),
LabeledDistributionMetric {
kind: DistributionMetricKind::Timing,
display_name: "Suggest query time",
ping: "metrics",
category: "suggest",
metric: "ingest_query_time",
axis_label: "time (us)",
value_divisor: Some(1_000),
value_filter: None,
applications: vec![Desktop],
}
.into(),
],
main_dashboard_metrics: vec![],
extra_dashboards: vec![],
},
TeamConfig {
team_name: "Credential Management",
components: vec![Component::Logins],
component_errors: true,
sync_metrics: true,
sync_metrics: false,
main_dashboard_metrics: vec![],
extra_dashboards: vec![],
},
Expand Down