Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15855 +/- ##
==========================================
+ Coverage 79.22% 79.55% +0.33%
==========================================
Files 159 160 +1
Lines 8287 8436 +149
==========================================
+ Hits 6565 6711 +146
- Misses 1722 1725 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d7ba03b to
eb19c44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👷 Running into some WebKit bug ignoring thickness on direct flex element. (May need a tweak in actual markup, or just living with it…)
One-line summary
Simplifying hover underlines on main menu, dropdowns and footer links: Moving from borders or fills on pseudo elements to native text decoration for better resilience.
Significant changes and points to review
Accomplishing the same effect while being less fragile.
(Real typographic underline makes descenders more legible by avoiding them instead of crossing.)
Changing to relative distance to adapt better to type scaling.
🚧 WIP
(Status: MVP-level, missing some QA and tree shaking, cleanup and tracking down more leftovers no longer needed. TBD next steps about WebKit if no solution deems practical.)
Issue / Bugzilla link
Fixes #15850
Testing
Ready to test, nb: difference in thickness in main nav between Gecko/Blink vs. WebKit…