Open
Conversation
Marks applied to fixtures have no effect and are now an error in pytest 9 (PytestRemovedIn9Warning). All test functions using this fixture already have their own @pytest.mark.cdn decorator.
Newer Selenium enforces W3C WebDriver spec compliance, rejecting vendor-specific capabilities (avoidProxy, tags) at the top level. These must be nested under sauce:options.
Collaborator
For https://github.com/mozilla/bedrock/actions/runs/21957292026/job/63424850468, it looks like the submit button was clickable but timed out. It might be caused by https://github.com/mozmeao/springfield/blob/main/media/js/newsletter/form-utils.es6.js#L90. If we are using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This catches up with straggling version bumps that historically were painful around pytest-selenium, but I figured it was time to bite the bullet
And.... integration tests are... seemingly happy, but have some error annotations, oddly: https://github.com/mozilla/bedrock/actions/runs/21957292026 and https://github.com/mozilla/bedrock/actions/runs/21959245804 - are these false positives or tolerable negatives @maureenlholland @wen-2018 ?