Skip to content

fix(gql): fix typo 'recieved' to 'received' in metrics opt state error #19930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sreecharan-desu wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(gql): fix typo 'recieved' to 'received' in metrics opt state error #19930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/fxa-graphql-api/src/gql/account.resolver.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ describe('#integration - AccountResolver', () => {

describe('deleteSecondaryEmail', () => {
it('succeeds', async () => {
authClient.recoveryEmailDestroyWithJwt = jest.fn().mockResolvedValue(true);
authClient.recoveryEmailDestroyWithJwt = jest
.fn()
.mockResolvedValue(true);
const result = await resolver.deleteSecondaryEmail(headers, {
jwt: 'jwtToken',
clientMutationId: 'testid',
Expand Down Expand Up @@ -576,7 +578,7 @@ describe('#integration - AccountResolver', () => {
state: 'In' as 'in',
})
).rejects.toThrow(
'Invalid metrics opt state! State must be in or out, but recieved In.'
'Invalid metrics opt state! State must be in or out, but received In.'
);
});
});
Expand Down
8 changes: 6 additions & 2 deletions packages/fxa-graphql-api/src/gql/account.resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,11 @@ export class AccountResolver {
@GqlXHeaders() headers: Headers,
@Args('input', { type: () => EmailInput }) input: EmailInput
): Promise<BasicPayload> {
await this.authAPI.recoveryEmailDestroyWithJwt(input.jwt, input.email, headers);
await this.authAPI.recoveryEmailDestroyWithJwt(
input.jwt,
input.email,
headers
);
return { clientMutationId: input.clientMutationId };
}

Expand Down Expand Up @@ -456,7 +460,7 @@ export class AccountResolver {

if (!['in', 'out'].includes(input.state)) {
throw new Error(
`Invalid metrics opt state! State must be in or out, but recieved ${input.state}.`
`Invalid metrics opt state! State must be in or out, but received ${input.state}.`
);
}

Expand Down