Game Submission Page

[birkanu]

User can add multiple screenshots now, but the code needs to be polished. I am still working on it, and will be making fixes soon.

[cvan]

single quotes

[birkanu]

@cvan Dropzone does not work yet, @yangshun I am still working on it, I know there are some bugs. I just wanted to submit a pull request so that Chris knows what I have done so far.

[yangshun]

Things done:

• UI implemented.
• Icon upload functionality implemented.
• Video preview functionality implemented.
• Drag and drop for icon (128 px).

Things incomplete:

• Replicate upload functionality to screenshots.
• Launch editor with different config for different media (icons (128x128), screenshots(4:3 and 16:9))

@cvan Is there a need to support both dimensions for the screenshots? When we load the game details in a game edit form, I'll render in the respective columns according to the image size ratio?

[cvan]

yes we need to support both aspect ratios. We will alter game detail page to render appropriately.

[cvan]

You can't chain vendor-prefixed selectors with a comma. The browsers' CSS parsers choke. Also why WebKit? What are you trying to change?

[yangshun]

Are we going to change the format of game data to support screenshots of both ratios? Actually aviary does not allow us to crop out 1024 x 768 photos (Max is like 600+?). Could you give the aviary editor (for screenshots) a shot and see?

[cvan]

Are we going to change the format of game data to support screenshots of both ratios? Actually aviary does not allow us to crop out 1024 x 768 photos (Max is like 600+?). Could you give the aviary editor (for screenshots) a shot and see?

can you show me a screenshot? and what do you mean "crop out"?

and it just needs to be an aspect ratio of 1024x768 (4:3) or 1280x720 (16:9). when developers upload full-screen screenshots, they should be in 4:3 or 16:9 (proportions of 1024x768 or 1280x720). and if they're not, we should allow the user to crop into those proportions.

[yangshun]

As you can see, the maximum width of the image that they can crop out is ~665. If we just need it to be that ratio, maybe we should remove the text 1024x768 and 1280x720?

[yangshun]

Things left to be done:

• Replicate screenshots CRUD to the 16:9 column
• Use media-item macro for icons and screenshots
• Write youtube/vimeo extractor for video url input
• Submission should extract out screenshots URLs

[cvan]

cache $(e.target) as a variable or use $(this).

[cvan]

are you guys good to go here?

[yangshun]

Hey @cvan , a few issues:

• How are we going to save the screenshots urls of different ratios? Could we split up the screenshot objects further into more keys? Currently it is as such:

"screenshots": [
        {
            "height": 1024,
            "src": "http://www.digitaltrends.com/wp-content/uploads/2011/02/nintendo-new-super-mario-bros-ds-art-screenshot.jpg",
            "width": 573
        },
        {
            "height": 1024,
            "src": "http://splitkick.com/wp-content/uploads/2013/01/newsuper2img.jpg",
            "width": 576
        },
        {
            "height": 1024,
            "src": "http://www.mariowiki.com/images/f/fc/SuperMarioBrosArtwork2.jpg",
            "width": 673
        }
    ],

Maybe it can be like this:

"screenshots": [{
     "4_3": [
        {
            "height": 1024,
            "src": "http://www.digitaltrends.com/wp-content/uploads/2011/02/nintendo-new-super-mario-bros-ds-art-screenshot.jpg",
            "width": 573
        }
    ],
    "16_9": [
        {
            "height": 1024,
            "src": "http://splitkick.com/wp-content/uploads/2013/01/newsuper2img.jpg",
            "width": 576
        },
        {
            "height": 1024,
            "src": "http://www.mariowiki.com/images/f/fc/SuperMarioBrosArtwork2.jpg",
            "width": 673
        }
    ]
}]

• Shall we store the videos as the following form instead?

"videos": [
    {
        "id": "xDLmN84RQbo",
        "type": "youtube",
        "thumbnail": "<thumbnail url here>"
    },
    {
        "id": 14628852,
        "type": "vimeo",
        "thumbnail": "<thumbnail url here>"
    },
]

Ultimately we are only concerned about the type, id and screenshot thumbnail image. It is unnecessary to parse the URL each time to extract out the ID and get the screenshot via an API (in the case of Vimeo).

[cvan]

@yangshun I approve of these changes. thank you.

[cvan]

r? @emoore24 @birkanu @scottmeng can you help review this?

[scottmeng]

👍

[yangshun]

@cvan I have completed implementation for this page. However, I'm facing problems submitting because the screenshots, videos and icons keys have nested content. This is what is saved in redis:

Suggestions? @cvan @soedar @scottmeng

[yangshun]

@birkanu would you be available to make the submission and editing of the game form work? Basically now the problem is that the game object is very complex and restify is unable to parse it.

The page interaction, loading of existing games works fine. Just can't submit and save.

[yangshun]

@cvan Is it possible to merge into master before fixing the submission/editing endpoint? This pull request is getting too large >_<

[birkanu]

@yangshun I can give it a try with the remaining 4 days I have left with school. @cvan we should merge this into master, and open another issue about restify not being able to parse the game object.