Skip to content

fix ref problem#1393

Merged
mozza-wins merged 1 commit intomainfrom
molly/sum
Feb 12, 2026
Merged

fix ref problem#1393
mozza-wins merged 1 commit intomainfrom
molly/sum

Conversation

@mozza-wins
Copy link
Contributor

No description provided.

Copy link
Contributor

@jaredsnyder jaredsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mozza-wins mozza-wins added this pull request to the merge queue Feb 12, 2026
@github-actions
Copy link

Integration report for "this commit"

lookml.diff

Click to expand!
Only in /tmp/workspace/looker-hub/firefox_ios: dashboards
Only in /tmp/workspace/looker-hub/marketing: datagroups
Only in /tmp/workspace/looker-hub/search_private/datagroups: search_term_data_validation_reports_last_updated.datagroup.lkml
Only in /tmp/workspace/looker-hub/search_private/datagroups: search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml
Only in /tmp/workspace/looker-hub/: user_journey
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/ads/views/campaigns_monthly.view.lkml /tmp/workspace/generated-lookml/ads/views/campaigns_monthly.view.lkml
--- /tmp/workspace/looker-hub/ads/views/campaigns_monthly.view.lkml	2026-02-12 17:22:02.816195675 +0000
+++ /tmp/workspace/generated-lookml/ads/views/campaigns_monthly.view.lkml	2026-02-12 17:21:57.935196032 +0000
@@ -186,17 +186,17 @@
   }
 
   measure: booked_rate {
-    sql: SAFE_DIVIDE(${booked_budget}, ${sold_quantity}) ;;
+    sql: SAFE_DIVIDE(${booked_budget}, ${total_sold_quantity}) ;;
     type: number
   }
 
   measure: cpc {
-    sql: SAFE_DIVIDE(${booked_budget}, ${budgeted_clicks}) ;;
+    sql: SAFE_DIVIDE(${booked_budget}, ${booked_clicks}) ;;
     type: number
   }
 
   measure: cpm {
-    sql: SAFE_DIVIDE(${booked_budget}, ${budgeted_impressions}) * 1000 ;;
+    sql: SAFE_DIVIDE(${booked_budget}, ${booked_impressions}) * 1000 ;;
     type: number
   }
 
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/fenix/views/metrics.view.lkml /tmp/workspace/generated-lookml/fenix/views/metrics.view.lkml
--- /tmp/workspace/looker-hub/fenix/views/metrics.view.lkml	2026-02-12 17:22:02.835195674 +0000
+++ /tmp/workspace/generated-lookml/fenix/views/metrics.view.lkml	2026-02-12 17:21:57.981196028 +0000
@@ -9515,24 +9515,6 @@
 "
   }
 
-  dimension: metrics__boolean__extensions_allow_execute_script_in_moz_extension {
-    label: "Extensions: Allow Execute Script In Moz Extension"
-    hidden: no
-    sql: ${TABLE}.metrics.boolean.extensions_allow_execute_script_in_moz_extension ;;
-    type: yesno
-    group_label: "Extensions"
-    group_item_label: "Allow Execute Script In Moz Extension"
-
-    link: {
-      label: "Glean Dictionary reference for Extensions: Allow Execute Script In Moz Extension"
-      url: "https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/extensions_allow_execute_script_in_moz_extension"
-      icon_url: "https://dictionary.telemetry.mozilla.org/favicon.png"
-    }
-
-    description: "Corresponds to the value of `extensions.webextensions.allow_executeScript_in_moz_extension` pref.
-"
-  }
-
   dimension: metrics__quantity__extensions_apis_dnr_evaluate_rules_count_max {
     label: "Extensions Apis Dnr: Evaluate Rules Count Max"
     hidden: no
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml	2026-02-12 17:22:02.882195670 +0000
+++ /tmp/workspace/generated-lookml/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: firefox_for_families_forecasted_expectations_last_updated {
-  label: "firefox_for_families_forecasted_expectations Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `mozdata`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'analysis' AND table_name = 'marketing_firefox_for_families_forecasted_expectations')
-
-    ) ;;
-  description: "Updates for firefox_for_families_forecasted_expectations when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/namespaces.yaml /tmp/workspace/generated-lookml/namespaces.yaml
--- /tmp/workspace/looker-hub/namespaces.yaml	2026-02-12 17:22:03.567195621 +0000
+++ /tmp/workspace/generated-lookml/namespaces.yaml	2026-02-12 17:22:03.496195626 +0000
@@ -289,13 +289,13 @@
           sql: ${budgeted_impressions}
           type: sum
         booked_rate:
-          sql: SAFE_DIVIDE(${booked_budget}, ${sold_quantity})
+          sql: SAFE_DIVIDE(${booked_budget}, ${total_sold_quantity})
           type: number
         cpc:
-          sql: SAFE_DIVIDE(${booked_budget}, ${budgeted_clicks})
+          sql: SAFE_DIVIDE(${booked_budget}, ${booked_clicks})
           type: number
         cpm:
-          sql: SAFE_DIVIDE(${booked_budget}, ${budgeted_impressions}) * 1000
+          sql: SAFE_DIVIDE(${booked_budget}, ${booked_impressions}) * 1000
           type: number
         total_delivered_revenue:
           sql: ${delivered_revenue}
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml	2026-02-12 17:22:02.931195667 +0000
+++ /tmp/workspace/generated-lookml/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: search_term_data_validation_reports_last_updated {
-  label: "search_term_data_validation_reports Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'search_terms_derived' AND table_name = 'search_term_data_validation_reports_v1')
-
-    ) ;;
-  description: "Updates for search_term_data_validation_reports when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml	2026-02-12 17:22:02.931195667 +0000
+++ /tmp/workspace/generated-lookml/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: search_term_sanitization_job_metadata_daily_last_updated {
-  label: "search_term_sanitization_job_metadata_daily Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'search_terms_derived' AND table_name = 'sanitization_job_metadata_v2')
-
-    ) ;;
-  description: "Updates for search_term_sanitization_job_metadata_daily when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/user_journey/views/events_daily.view.lkml /tmp/workspace/generated-lookml/user_journey/views/events_daily.view.lkml
--- /tmp/workspace/looker-hub/user_journey/views/events_daily.view.lkml	2026-02-12 17:22:02.935195667 +0000
+++ /tmp/workspace/generated-lookml/user_journey/views/events_daily.view.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,71 +0,0 @@
-view: events_daily {
-  sql_table_name: `mozdata.messaging_system.events_daily`
-    ;;
-
-  dimension: addon_version {
-    type: string
-    sql: ${TABLE}.addon_version ;;
-  }
-
-  dimension: app_version {
-    type: string
-    sql: ${TABLE}.app_version ;;
-  }
-
-  dimension: city {
-    type: string
-    sql: ${TABLE}.city ;;
-  }
-
-  dimension: client_id {
-    type: string
-    sql: ${TABLE}.client_id ;;
-  }
-
-  dimension: country {
-    type: string
-    map_layer_name: countries
-    sql: ${TABLE}.country ;;
-  }
-
-  dimension: events {
-    type: string
-    sql: ${TABLE}.events ;;
-    hidden: yes
-  }
-
-  dimension: experiments {
-    hidden: yes
-    sql: ${TABLE}.experiments ;;
-  }
-
-  dimension: locale {
-    type: string
-    sql: ${TABLE}.locale ;;
-  }
-
-  dimension: normalized_channel {
-    type: string
-    sql: ${TABLE}.normalized_channel ;;
-  }
-
-  dimension: os {
-    type: string
-    sql: ${TABLE}.os ;;
-  }
-
-  dimension: sample_id {
-    type: number
-    sql: ${TABLE}.sample_id ;;
-  }
-
-  dimension: subdivision1 {
-    type: string
-    sql: ${TABLE}.subdivision1 ;;
-  }
-
-  dimension: submission_date {
-    type: date
-    sql: CAST(${TABLE}.submission_date AS TIMESTAMP) ;;
-  }
-}

Link to full diff

Merged via the queue into main with commit cdc9fa8 Feb 12, 2026
18 checks passed
@mozza-wins mozza-wins deleted the molly/sum branch February 12, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants