Skip to content

remove newtab_clients_daily from looker definitions #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaredsnyder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove newtab_clients_daily from looker definitions #1237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions looker/definitions/firefox_desktop.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,6 @@ select_expression = "SUM(sponsored_topsite_click_count)"
friendly_name = "Sum of Sponsored Topsite Clicks "
description = "Sum of sponsored topsite clicks"

[metrics.sponsored_impressions]
data_source = "newtab_clients_daily"
select_expression = "SUM(sponsored_pocket_impressions) + SUM(sponsored_topsite_tile_impressions)"
friendly_name = "Sponsored Impressions"
type = "scalar"
description = """
Total number of sponsored impressions across content and tiles on New Tab
"""

[metrics.any_topsite_impression_count.statistics.sum]
[metrics.organic_topsite_impression_count.statistics.sum]
[metrics.sponsored_topsite_impression_count.statistics.sum]
Expand Down Expand Up @@ -409,31 +400,6 @@ denominator = "sponsored_tile_impressions.sum"
numerator = "sponsored_pocket_clicks.sum"
denominator = "sponsored_pocket_impressions.sum"


[metrics.sponsored_pocket_impressions_per_client]
data_source = "newtab_clients_daily"
select_expression = "SUM(1)"
friendly_name = "Sponsored Pocket Impressions Per Client"
description = """
Number of sponsored content impressions divided by number of clients
"""

[metrics.sponsored_tile_impressions_per_client]
data_source = "newtab_clients_daily"
select_expression = "SUM(1)"
friendly_name = "Sponsored Topsite Tile Impressions Per Client"
description = """
Number of sponsored topsite tile impressions divided by number of clients
"""

[metrics.sponsored_impressions_per_client]
data_source = "newtab_clients_daily"
select_expression = "SUM(1)"
friendly_name = "Sponsored Impressions Per Client"
description = """
Number of sponsored impressions (content and tiles on New Tab) divided by number of clients
"""

[metrics.sponsored_pocket_impressions_per_client.statistics.ratio]
numerator = "sponsored_pocket_impressions.sum"
denominator = "sponsored_impressions.client_count"
Expand Down Expand Up @@ -505,13 +471,6 @@ columns_as_dimensions = true
relationship = "one_to_many"
on_expression = "desktop_engagement_v1.country = countries.code"

[data_sources.newtab_clients_daily]
columns_as_dimensions = true

[data_sources.newtab_clients_daily.joins.countries]
relationship = "one_to_many"
on_expression = "newtab_clients_daily.country_code = countries.code"

#HNT data model revamp data sources
[data_sources.newtab_clients_daily_aggregates]
from_expression = "moz-fx-data-shared-prod.firefox_desktop_derived.newtab_clients_daily_aggregates_v2"
Expand Down