Skip to content
This repository was archived by the owner on Feb 18, 2019. It is now read-only.

Comments

upgrade for django 1.6#4

Open
washort wants to merge 2 commits intomozilla:masterfrom
washort:master
Open

upgrade for django 1.6#4
washort wants to merge 2 commits intomozilla:masterfrom
washort:master

Conversation

@washort
Copy link
Contributor

@washort washort commented Feb 15, 2014

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this also work on Django 1.4 and 1.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what uses those? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a 3rd party app that could be included in projects that use older Django versions, this patch should consider it. Django 1.4 especially is a long-term support release and many people will stay on it for awhile.

@robhudson
Copy link
Contributor

I don't see that we're using this at all in zamboni. The Jingo monkeypatch does the same thing and I've submitted a PR to update that here: jbalogh/jingo#62

My vote would be to remove this file completely and have people use the jingo one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants