This repository was archived by the owner on May 7, 2018. It is now read-only.
Fix to issue #30 #33
Open
Fix to issue #30 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh, wow! This took so few lines of code too! I'm glad the jws package was properly updated. The Travis build is failing though, so let's see if we can marshall some review from Mozilla, fix whatever check is failing and then get this put into production. Thanks so much for working on it! |
Merged
Contributor
|
Incidentally, |
Contributor
|
This can be closed: These changes were incorporated in https://github.com/mozilla/openbadges-validator/pull/34/files |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a fix to the issue described here #30.
The problem is that jws library that's bundle with openbadges-validator is too old and don't work properly with ECDSA signatures. This pull request updates the package dependencies version and some changes to the code in order to work with the new library version.