Merged
Conversation
Contributor
|
@stephaniehobson Is there a chance to fix mozilla/protocol-assets#96, release a minor Lines 35 to 36 in e5627f8 |
alexgibson
approved these changes
Mar 14, 2025
Contributor
alexgibson
left a comment
There was a problem hiding this comment.
r+ (I'll leave it up to you if you on the question from @janbrasna)
Contributor
Author
|
@janbrasna I'll do a follow up to get it into 19.3.1 (or whatever is appropriate) |
Contributor
|
@stephaniehobson Awesome! Just wanted to mention it, not having to update downstream several times afterwards. — If you have another release in cards anyways, I'll submit two more fixes here in a bit so it's a worthwhile bump;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Protocol to v19.3.0.