Remove unused /bin CI scripts#1034
Merged
alexgibson merged 2 commits intomozilla:mainfrom Apr 15, 2025
Merged
Conversation
stevejalim
approved these changes
Apr 15, 2025
stevejalim
left a comment
stevejalim
left a comment
There was a problem hiding this comment.
Yeah I can't see how slack is pinged from here, but it doesn't look like it's from the shell script. R+ and 🤞
|
@maureenlholland Feel free to merge whenever it suits you |
Collaborator
|
@stevejalim thanks! you can go ahead and merge here. I don't have push access for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These come from times of Jenkins and GitLab CI, with S3 as the deployment — none of which is currently in use. Site is currently built at Netlify via hooks/oauth app plugged directly into VCS/GH, both for prod and stage (and demo branches as well), following its config toml and manifest scripts exclusively.
I have documented this change in the design system.I have recorded this change inCHANGELOG.md.Testing
Not used most likely even elsewhere less visible, as the
node:16image would be complaining about compatibility otherwise, as deps are already bumped beyond that.(While I don't have
#www-notifyaccess, my guess is the deployment status from MZP is not being posted there anyways, at least not via this script, as it expectsslack-clion the runner which probably was configured on moz.works blue CI Jenkins instance, but here it's most likely not set up, incl. any secrets, right? Any current integration would useslackapi/slack-github-actioninstead, withSLACK_BOT_TOKENconfigured in the env secrets for more native GHA approach…)