-
Notifications
You must be signed in to change notification settings - Fork 2
Update experimenter api environment variable (as part of Android PR) #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
8b953e2
Update TODO list
dmose 21ecd44
Add basic instructions for copilot case sensitivity.
dmose 6a0112e
Refactor page.tsx to call fetchData and pass params
dmose b3b9a94
Fixup Android calling of Dashboard component.
dmose 9e18ede
Made localData optional to Dashboard component
dmose e31c39e
Make the file case instructions clearer
dmose 6f199bb
Fixup dashboard test
dmose 487c0c7
Move platform to a union type
dmose c5e2a1e
Refactor fetchData to its own file
dmose 0340475
Renamed fetchData.tsx to fetchData.ts
dmose ebe78b0
Export compareDatesFn to fix the app
dmose dccc2a0
Remove obsolete fetchData.tsx
dmose a85e012
Move getASRouterLocalMessageIntoFromFile to fetchData.ts
dmose deef435
Move getASRouterLocalColumnFromJSON to fetchData.ts
dmose 4ed15b0
Remove extra copy of getMsgExpRecipeCollection from dashboard.tsx
dmose 05e7baa
Remove dead code
dmose f95527b
Move appendFxMSTelemetryData to fetchData.ts
dmose 1887313
Move functions to fetchData and clean up
dmose a8c8fbb
Appease prettier
dmose 92605cc
Update comment about fetchData file home
dmose 84d2601
Formatting tweaks
dmose db42cee
Update TODO list
dmose 31dc009
Flesh out Android standup plan
dmose 20b3e7a
Minor TODO update
dmose a9002b1
Add WIP MOBILE-EPICS list
dmose 43a56a8
Update mobile epics
dmose 2b3b3c9
Appease prettier
dmose 3c89b3b
Create platformInfo object
dmose 9465ea5
Added a test to check for correct URL construction
dmose 6847744
Move experiments path component to a more sensible env var
dmose 73566a4
Standarize platform typing to the nimbus platform slug strings
dmose e248a93
Fix platformDisplayName use
dmose 5ad4470
Remove some env vars for modularity
dmose 06c3907
Clean up PR to review
sarahhjchung 49ee43b
Add more comments and update isCompleted boolean
sarahhjchung dda789c
Update README, CONTRIBUTING, and CHANGELOG
sarahhjchung 4774e72
Make fetchData for mobile default to live
sarahhjchung a460216
Update CHANGELOG
sarahhjchung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # GitHub Copilot Instructions | ||
|
|
||
| ## Case-Sensitive Filesystem | ||
|
|
||
| Some of our development happens on a case-sensitive filesystem. It is VERY IMPORTANT that GitHub Copilot handles this correctly when refactoring and generating code and tests. | ||
|
|
||
| ### Guidelines | ||
|
|
||
| 1. **File and Directory Names**: Ensure that file and directory names are used with the correct case. For example, `MyFile.ts` and `myfile.ts` are different files on a case-sensitive filesystem. | ||
| 2. **Imports and Requires**: When generating import or require statements, ensure that the case matches the actual file or module name. | ||
| 3. **Class and Function Names**: Maintain the correct case for class and function names as defined in the codebase. | ||
| 4. **Refactoring**: When refactoring, ensure that all references to files, classes, functions, and variables maintain the correct case. | ||
|
|
||
| ### Specific Instructions for Component Files | ||
|
|
||
| When working with component files where the component name is uppercase and the file name contains lowercase, ensure the following: | ||
|
|
||
| 1. **Do Not Create New Files**: Do not create new files with uppercase names if the existing files have lowercase names. | ||
| 2. **Correct File Names**: Use the existing files with the correct case. | ||
| 3. **Correct Imports**: When importing components in other files, ensure the import statement uses the correct case: | ||
| ```tsx | ||
| import Component from "@/app/component"; | ||
| ``` | ||
|
|
||
| By following these guidelines, we can avoid issues related to case sensitivity and unnecessary file creation in our development process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # GitHub Copilot Instructions | ||
|
|
||
| ## Case-Sensitive Filesystem | ||
|
|
||
| Some of our development happens on a case-sensitive filesystem. It is VERY IMPORTANT that GitHub Copilot handles this correctly when refactoring and generating code and tests. | ||
|
|
||
| ### Guidelines | ||
|
|
||
| 1. **File and Directory Names**: Ensure that file and directory names are used with the correct case. For example, `MyFile.ts` and `myfile.ts` are different files on a case-sensitive filesystem. | ||
| 2. **Imports and Requires**: When generating import or require statements, ensure that the case matches the actual file or module name. | ||
| 3. **Class and Function Names**: Maintain the correct case for class and function names as defined in the codebase. | ||
| 4. **Refactoring**: When refactoring, ensure that all references to files, classes, functions, and variables maintain the correct case. | ||
|
|
||
| ### Specific Instructions for Component Files | ||
|
|
||
| When working with component files where the component name is uppercase and the file name contains lowercase, ensure the following: | ||
|
|
||
| 1. **Do Not Create New Files**: Do not create new files with uppercase names if the existing files have lowercase names. | ||
| 2. **Correct File Names**: Use the existing files with the correct case. | ||
| 3. **Correct Imports**: When importing components in other files, ensure the import statement uses the correct case: | ||
| ```tsx | ||
| import Component from "@/app/component"; | ||
| ``` | ||
|
|
||
| By following these guidelines, we can avoid issues related to case sensitivity and unnecessary file creation in our development process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,25 @@ | ||
| import { Dashboard } from "@/app/dashboard"; | ||
| import { fetchData } from "@/app/fetchData"; | ||
| import { Platform } from "@/lib/types"; | ||
|
|
||
| export default function Page() { | ||
| return <Dashboard platform={"android"} />; | ||
| const platform: Platform = "fenix"; | ||
|
|
||
| export default async function Page() { | ||
| const { | ||
| localData, | ||
| experimentAndBranchInfo, | ||
| totalExperiments, | ||
| msgRolloutInfo, | ||
| totalRolloutExperiments, | ||
| } = await fetchData(platform); | ||
|
|
||
| return ( | ||
| <Dashboard | ||
| platform={platform} | ||
| experimentAndBranchInfo={experimentAndBranchInfo} | ||
| totalExperiments={totalExperiments} | ||
| msgRolloutInfo={msgRolloutInfo} | ||
| totalRolloutExperiments={totalRolloutExperiments} | ||
| /> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that this file and
copilot-instructions.mdhave the same contents?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the commit 374cd7a when these docs were added, they look to be intentionally the same. So I'll leave them as is and confirm with Dan!