-
Notifications
You must be signed in to change notification settings - Fork 10
Reject calls when already in a call on mobile #37
base: master
Are you sure you want to change the base?
Conversation
static/mobile.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the audioOnly variable in here, so maybe move that test and early return just after the "var data = " ... line?
Automatically reject calls if we're already in another call on mobile. Improve the UI to provide a meaningful warning for the caller.
static/chatWindow.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't most (of not all) of these rules duplicated with #callAnswer?
static/sidebar.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style: please fix the indent here.
|
From IRC: a random guess is that the reject message could be going to B instead of A when C clicks "reject" Not sure what the conclusion of the IRC discussion was, so I'm pasting my IRC comments here for future reference. I really like these changes otherwise :). |
Conflicts: static/sidebar.js
static/sidebar.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This timer needs to be cancelled when the user closes the floating window by hand. Otherwise, it may execute if the user starts another call with the same contact; that's what caused the bug I mentioned at #37 (comment)
|
Automatically reject calls if we're already in another call on mobile.
Improve the UI to provide a meaningful warning for the caller.