Enable content localization for iOS summarizer landing page#476
Draft
janbrasna wants to merge 2 commits intomozmeao:mainfrom
Draft
Enable content localization for iOS summarizer landing page#476janbrasna wants to merge 2 commits intomozmeao:mainfrom
janbrasna wants to merge 2 commits intomozmeao:mainfrom
Conversation
This reverts commit 18754a8.
janbrasna
added
Do Not Merge
janbrasna
changed the title
Collaborator
Author
|
FYI @issammani this is waiting for when you need to start localizing https://www.firefox.com/landing/ios-summarizer/ for other languages as well — if you plan to use the page further and wanted to open to all locales. Just ping to get this in motion. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Reverts moving the ftl content to just en-US — to enable all l10n for the landing page.
Significant changes and points to review
Will also need deleting the en-US file in l10n repo(s) too, as the automation doesn't do removals.
Issue / Bugzilla link
mozilla-l10n/www-firefox-l10n#72 (comment)
Testing
This is DNM until necessary (the feature is currently restricted to en-US — once rollout changes this could ship to trigger translations).
┆Issue is synchronized with this Jira Task
┆Priority: P3
┆Sprint: Backlog