Skip to content

page meta title tweaks - WT118 (fix #385)#900

Open
wen-2018 wants to merge 3 commits intomainfrom
page-title-tweaks
Open

page meta title tweaks - WT118 (fix #385)#900
wen-2018 wants to merge 3 commits intomainfrom
page-title-tweaks

Conversation

@wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Jan 9, 2026

One-line summary

This PR updates some page titles to avoid repetition.

Significant changes and points to review

/browsers/mobile/ios/
/browsers/desktop/
/browsers/mobile/

meta title

Issue / Bugzilla link

#385

Testing

http://localhost:8000/browsers/mobile/ios/
http://localhost:8000/browsers/desktop/
http://localhost:8000/browsers/mobile/

@wen-2018 wen-2018 marked this pull request as ready for review January 12, 2026 20:14
Copy link
Collaborator

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this was discussed before feel free to disregard the comments, I just thought I'd leave here what I felt could be the options when looking into the differences:

(Also wondering, how to differentiate UK vs. US titles a slightly more, like using "from" vs. "by" in them, but leaving that for a reviewer better equipped for language tweaks;D)

@wen-2018 wen-2018 added Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review labels Jan 14, 2026
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jan's comments that we should use by Mozilla to avoid too much Firefox repetition

@maureenlholland maureenlholland removed the Needs Review Awaiting code review label Feb 11, 2026
@maureenlholland maureenlholland self-assigned this Feb 11, 2026
@janbrasna
Copy link
Collaborator

janbrasna commented Feb 13, 2026

I had some notes originally in #385 — with perhaps a little more intricate disambiguation for some of the key pages, also with ideas about moving the prefix+suffix 3-section titles in some places to just 2-section content when customizing. Also /browsers/mobile does not appear to use the same way of separating the different English variations to help them not get duped against each other in search results. Ah I see mobile/index does not disambiguate but then deeper e.g. mobile/ios does so it's probably fine at that level.

Not sure if there's e.g. meta content already available for what should end up in the CMS versions of the pages, to use that as an inspiration for updates to the static templates as well?

wen-2018 and others added 2 commits February 13, 2026 16:42
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.50%. Comparing base (b7da749) to head (3918b1b).
⚠️ Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   82.15%   79.50%   -2.65%     
==========================================
  Files         117      121       +4     
  Lines        6208     7154     +946     
==========================================
+ Hits         5100     5688     +588     
- Misses       1108     1466     +358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend HTML, CSS, JS... client side stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants