Conversation
janbrasna
left a comment
There was a problem hiding this comment.
In case this was discussed before feel free to disregard the comments, I just thought I'd leave here what I felt could be the options when looking into the differences:
(Also wondering, how to differentiate UK vs. US titles a slightly more, like using "from" vs. "by" in them, but leaving that for a reviewer better equipped for language tweaks;D)
springfield/firefox/templates/firefox/browsers/desktop/index.html
Outdated
Show resolved
Hide resolved
springfield/firefox/templates/firefox/browsers/desktop/index.html
Outdated
Show resolved
Hide resolved
springfield/firefox/templates/firefox/download/desktop/base.html
Outdated
Show resolved
Hide resolved
springfield/firefox/templates/firefox/download/desktop/base.html
Outdated
Show resolved
Hide resolved
maureenlholland
left a comment
There was a problem hiding this comment.
I agree with Jan's comments that we should use by Mozilla to avoid too much Firefox repetition
|
I had some notes originally in #385 — with perhaps a little more intricate disambiguation for some of the key pages, also with ideas about moving the prefix+suffix 3-section titles in some places to just 2-section content when customizing. Not sure if there's e.g. meta content already available for what should end up in the CMS versions of the pages, to use that as an inspiration for updates to the static templates as well? |
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 82.15% 79.50% -2.65%
==========================================
Files 117 121 +4
Lines 6208 7154 +946
==========================================
+ Hits 5100 5688 +588
- Misses 1108 1466 +358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
One-line summary
This PR updates some page titles to avoid repetition.
Significant changes and points to review
/browsers/mobile/ios/
/browsers/desktop/
/browsers/mobile/
meta title
Issue / Bugzilla link
#385
Testing
http://localhost:8000/browsers/mobile/ios/
http://localhost:8000/browsers/desktop/
http://localhost:8000/browsers/mobile/