Show loader for disabled checkbox for download-as-default landing page - WT127 (fix #433)#905
Open
Show loader for disabled checkbox for download-as-default landing page - WT127 (fix #433)#905
Conversation
wen-2018
force-pushed
the
ui-improvement-for-landing-checkbox
branch
2 times, most recently
from
7030c8b to
9e131b0
Compare
wen-2018
changed the title
wen-2018
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 82.14% 81.73% -0.41%
==========================================
Files 117 113 -4
Lines 6210 6022 -188
==========================================
- Hits 5101 4922 -179
+ Misses 1109 1100 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wen-2018
force-pushed
the
ui-improvement-for-landing-checkbox
branch
from
9e131b0 to
5423ebf
Compare
wen-2018
added
Frontend
maureenlholland
requested changes
Feb 11, 2026
Collaborator
maureenlholland
left a comment
maureenlholland
left a comment
There was a problem hiding this comment.
requested change: spinner animation with no layout shift
suggested changes are non-blocking
| checkboxes[i].style.display = 'none'; | ||
| } | ||
|
|
||
| for (let i = 0; i < checkboxes.length; i++) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| for (let i = 0; i < checkboxes.length; i++) { | |
| for (let i = 0; i < loadingSigns.length; i++) { |
| const checkboxes = document.querySelectorAll('.default-browser-checkbox'); | ||
| const loadingSigns = document.querySelectorAll('.loading'); | ||
|
|
||
| for (let i = 0; i < checkboxes.length; i++) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| for (let i = 0; i < checkboxes.length; i++) { | |
| for (let i = 0; i < loadingSigns.length; i++) { |
| display: inline-block; | ||
| width: 24px; | ||
| height: 24px; | ||
| background: url('/media/img/icons/loading.svg') no-repeat center; |
Collaborator
There was a problem hiding this comment.
This is causing some layout shift, and it's a tough fit in general because the aspect ratio of the dots is more rectangular.
A spinner is probably going to fix into the square aspect ratio better: https://css-loaders.com/spinner/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
This PR adds a loader for temporarily disabled checkbox for Windows landing page download-as-default option.
Significant changes and points to review
Firefox on Windows landing page download-as-default checkbox.
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-127?atlOrigin=eyJpIjoiMjgyY2E5YThjOWU2NGRmMWI1MzliMjE4YmYwYzY0ODgiLCJwIjoiaiJ9
#433
Testing
http://localhost:8000/en-US Firefox on Windows