Add default browser checkbox to download button block#963
Add default browser checkbox to download button block#963maureenlholland merged 12 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 79.50% 79.55% +0.04%
==========================================
Files 121 121
Lines 7154 7169 +15
==========================================
+ Hits 5688 5703 +15
Misses 1466 1466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
one blocker around JS running when Wagtail checkbox setting is false
I guess the other difficult thing is this will affect all download buttons on the page, regardless of whether they have a checkbox. Maybe another point in help text?
the UTM param is added to URL and stub attribution cookie is updated for SET_DEFAULT_BROWSER, regardless of which button I press

Co-authored-by: maureenlholland <19650432+maureenlholland@users.noreply.github.com>
Co-authored-by: maureenlholland <19650432+maureenlholland@users.noreply.github.com>
|
@maureenlholland I also included here the fix for the Linux download buttons that should show both 32 and 64 buttons. |
|
@maureenlholland If you could give this another pass, we can get this merged. Note that Mariana is out next week, so if there are more revisions that are needed, let me know. |
|
updates resolve previous requested changes ✅ going to look at conflict resolutions |
| DownloadAsDefault.processAttributionRequest(true); | ||
| // processAttributionRequest will bind the events | ||
| const checkboxes = document.querySelectorAll('.default-browser-checkbox'); | ||
| if (checkboxes.length > 0) { |
One-line summary
Add a new option to the Download Firefox Button block to display a "Set as default browser" checkbox.
Significant changes and points to review
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-643
Testing
./manage.py load_page_fixtures?utm_campaign=SET_DEFAULT_BROWSERquery should be added to the URLmoz-stub-attribution-codesource=(not set)&medium=(direct)&campaign=SET_DEFAULT_BROWSER&content=(not set)&experiment=(not set)&variation=(not set)&ua=chrome&client_id_ga4=491504120.1770734695&session_id=3307072354&dlsource=fxdotcom(note theSET_DEFAULT_BROWSERcampaign)source=(not set)&medium=(direct)&campaign=(not set)&content=(not set)&experiment=(not set)&variation=(not set)&ua=chrome&client_id_ga4=142934101.1770905600&session_id=8364667907&dlsource=fxdotcom(no SET_DEFAULT_BROWSER` campaign)