Skip to content

permit {.sref} links to individual paragraphs #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

permit {.sref} links to individual paragraphs #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/filters/wg21.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ def rm(): _diff('rmcolor', 'sout', 'del')

if 'sref' in elem.classes and isinstance(elem, pf.Span):
target = pf.stringify(elem)
number = stable_names.get(target)
number = stable_names.get(target.split('#')[0])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the fix. Can I suggest a minor change here where we do something like name = target.split('#')[0], then the debug message to print "stable name not found" rather than "stable name not found"?

link = pf.Link(
pf.Str(f'[{target}]'),
url=f'https://wg21.link/{target}')
Expand Down