Open
Conversation
The response coming back from LoC is looking like this: `<td><a href="/authorities/term_id_is_here" title="Click to view record">` instead of like this: `<td><a href="/authorities/term_id_is_here">` so the term_id is getting set to: `term_id_is_here" title="Click to view record` because the regex `"/(.+)\">"` is greedily taking everything up to the last `"` before the `>`. This commit changes the regex to `"/([^\"]+)\"[^>]*>"` which searches for `/`, followed by one or more characters that are not `"`, followed by `"`, followed by zero or more characters that are not `>`, followed by `>`. The group will now take only up to the first double quote character, so it will work no matter what other attributes are within the `<a>` element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The response coming back from LoC is looking like this:
<td><a href="/authorities/term_id_is_here" title="Click to view record">instead of like this:
<td><a href="/authorities/term_id_is_here">so the term_id is getting set to:
term_id_is_here" title="Click to view recordbecause the regex
"/(.+)\">"is greedily taking everything up to the last"before the>.This commit changes the regex to
"/([^\"]+)\"[^>]*>"which searches for/, followed byone or more characters that are not
", followed by", followed by zero or more charactersthat are not
>, followed by>. The group will now take only up to the first double quotecharacter, so it will work no matter what other attributes are within the
<a>element.