Fix broken regex in name reconciliation, use more recent libraries#8
Open
villanueval wants to merge 10 commits intomphilli:masterfrom
Open
Fix broken regex in name reconciliation, use more recent libraries#8villanueval wants to merge 10 commits intomphilli:masterfrom
villanueval wants to merge 10 commits intomphilli:masterfrom
Conversation
villanueval
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name reconciliation was not working. Seems the regex that extracted the link by looking at a
<td><a ...tag wasn't working anymore. Replaced with a bs4find_all.Updated the requirements to use modern versions of
requests,beautifulsoup4, andFlask. The original specified very old versions of these libraries.Tested in RHEL 8.8 and Ubuntu 18.04 using Python 3.6.8+.