chore(SHINE): make sampling configurable and skip when frac == 1#78
Merged
bryllewoody merged 1 commit intomqcomplab:mainfrom Sep 23, 2025
Merged
chore(SHINE): make sampling configurable and skip when frac == 1#78bryllewoody merged 1 commit intomqcomplab:mainfrom
bryllewoody merged 1 commit intomqcomplab:mainfrom
Conversation
Contributor
bryllewoody
commented
Sep 23, 2025
bryllewoody
commented
- run_shine.py: pass sampling variable into Shine
- shine.py: only apply diversity/quota sampling if frac < 1, otherwise keep full trajectories
- run_shine.py: pass sampling variable into Shine instead of hardcoding 'diversity' - shine.py: only apply diversity/quota sampling if frac < 1, otherwise keep full trajectories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.